I'd like to add HeapSnapshot::GetMaxSnapshotJSObjectId function.

This value is required for showing the heap snapshot delta in Summary view of DevTools.Profiler.
At the moment it is evaluating on the front-end side and this is cost us 2 * (load time + parse time + traverse via snapshot) because I need this value for two previous snapshots.

BUG=none
TEST=test-heap-profiler

[yurys, 2012-03-26 14:53:20]

https://chromiumcodereview.appspot.com/9858016/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/9858016/diff/1/src/profile-generator.c...
src/profile-generator.cc:1228: // Track only js objects. They has odd ids.
typo: has -> have

https://chromiumcodereview.appspot.com/9858016/diff/1/src/profile-generator.c...
src/profile-generator.cc:1336: printf("newId = %d\n", next_id_);
Remove this.

[loislo, 2012-03-26 15:01:43]

done

[mnaganov (inactive), 2012-03-26 15:55:37]

https://chromiumcodereview.appspot.com/9858016/diff/4001/src/api.cc
File src/api.cc (right):

https://chromiumcodereview.appspot.com/9858016/diff/4001/src/api.cc#newcode6161
src/api.cc:6161: return ToInternal(this)->max_snapshot_js_object_id();
Please add

i::Isolate* isolate = i::Isolate::Current();
IsDeadCheck(isolate, "v8::HeapSnapshot::GetMaxSnapshotJSObjectId");

https://chromiumcodereview.appspot.com/9858016/diff/4001/src/profile-generato...
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/9858016/diff/4001/src/profile-generato...
src/profile-generator.cc:1229: if (id % 2 && id > max_snapshot_js_object_id_)
Shouldn't you use HeapObjectMap::kObjectIdStep here?

[loislo, 2012-03-27 05:26:48]

comments addressed

[mnaganov (inactive), 2012-03-27 08:50:45]

lgtm