Issue 9858010: Complete switch to SnapshotObjectId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9858010: Complete switch to SnapshotObjectId. (Closed)

Created:
8 years, 9 months ago by loislo

Modified:
8 years, 9 months ago

Reviewers:
mnaganov (inactive)

CC:
yurys, alexeif

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Complete switch to SnapshotObjectId. BUG=none TEST=test-heap-profiler

Patch Set 2 : static_cast changed to int32_t #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -24 lines)			Patch
M	include/v8-profiler.h	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	src/api.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1	5 chunks	+19 lines, -19 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mnaganov (inactive)

https://chromiumcodereview.appspot.com/9858010/diff/1/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right): https://chromiumcodereview.appspot.com/9858010/diff/1/test/cctest/test-heap-profiler.cc#newcode350 test/cctest/test-heap-profiler.cc:350: #define CHECK_EQ_SNAPSHOT_OBJECT_ID(a, b) \ Have you considered simply using ...

8 years, 9 months ago (2012-03-26 10:46:25 UTC) #2