Dragging files (not dropping yet).

Dragging files (not dropping yet).

BUG=chromium-os:20162
TEST=Manual test.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128905

[dgozman, 2012-03-26 13:10:22]

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
File chrome/browser/resources/file_manager/css/file_manager.css (right):

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/css/file_manager.css:1103: /* Only nodes
in visiblt viewport will be rendered. */
typo: visibilt

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/css/file_manager.css:1112:
#drag-image-container > li {
If you make this |list|. and not a |div|, this styles should be applied
automatically.

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/js/file_manager.js:1307: const container =
this.document_.querySelector('#drag-image-container');
|container| and |self| are not used

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/js/file_manager.js:1311:
FileManager.prototype.onDragDtart_ = function(event) {
typo: onDragDtart -> onDragStart

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/js/file_manager.js:2173:
selection.dragNodes.push(new GridItem(this, entry));
Why do you create items here and not in dragstart?

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/js/file_manager.js:2190: //
entry.file([].push.bind(selection.files));
Commented code.

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/js/file_manager.js:2191:
entry.file(function(f) {
Again, why not in dragstart?

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/js/file_manager.js:3133:
FileManager.prototype.copySelectionToClipboard_ = function(event) {
Rename this to onCopy_ for consistency?

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/js/file_manager.js:3143:
FileManager.prototype.cutSelectionToClipboard_ = function(event) {
Rename this to onCut_ for consistency?

[SeRya, 2012-03-26 13:37:45]

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
File chrome/browser/resources/file_manager/css/file_manager.css (right):

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/css/file_manager.css:1103: /* Only nodes
in visiblt viewport will be rendered. */
On 2012/03/26 13:10:23, dgozman wrote:
> typo: visibilt

Done.

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/css/file_manager.css:1112:
#drag-image-container > li {
On 2012/03/26 13:10:23, dgozman wrote:
> If you make this |list|. and not a |div|, this styles should be applied
> automatically.

Done.

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/js/file_manager.js:2173:
selection.dragNodes.push(new GridItem(this, entry));
On 2012/03/26 13:10:23, dgozman wrote:
> Why do you create items here and not in dragstart?

Added comment describing the reason.

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/js/file_manager.js:2190: //
entry.file([].push.bind(selection.files));
On 2012/03/26 13:10:23, dgozman wrote:
> Commented code.

Done.

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/js/file_manager.js:2191:
entry.file(function(f) {
On 2012/03/26 13:10:23, dgozman wrote:
> Again, why not in dragstart?

Added comment describing the reason.

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/js/file_manager.js:3133:
FileManager.prototype.copySelectionToClipboard_ = function(event) {
On 2012/03/26 13:10:23, dgozman wrote:
> Rename this to onCopy_ for consistency?

Done.

https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resource...
chrome/browser/resources/file_manager/js/file_manager.js:3143:
FileManager.prototype.cutSelectionToClipboard_ = function(event) {
On 2012/03/26 13:10:23, dgozman wrote:
> Rename this to onCut_ for consistency?

Done.

[dgozman, 2012-03-26 13:50:45]

https://chromiumcodereview.appspot.com/9856014/diff/6001/chrome/browser/resou...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/9856014/diff/6001/chrome/browser/resou...
chrome/browser/resources/file_manager/js/file_manager.js:2197:
entry.file(function(f) {
1. This should not be done on GData.
2. Perhaps, add a TODO to cache these file objects?

https://chromiumcodereview.appspot.com/9856014/diff/6001/chrome/browser/resou...
chrome/browser/resources/file_manager/js/file_manager.js:3201:
this.document_.addEventListener('cut', this.onCutBount_);
typo: onCutBount_

[SeRya, 2012-03-26 14:00:17]

https://chromiumcodereview.appspot.com/9856014/diff/6001/chrome/browser/resou...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/9856014/diff/6001/chrome/browser/resou...
chrome/browser/resources/file_manager/js/file_manager.js:2197:
entry.file(function(f) {
On 2012/03/26 13:50:45, dgozman wrote:
> 1. This should not be done on GData.
> 2. Perhaps, add a TODO to cache these file objects?
1. Done.
2. I haven't seen any evidence such an optimization makes sense. I would like to
drop random thoughts in our code base.

[dgozman, 2012-03-26 14:14:47]

LGTM