Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 9856014: Dragging files (not dropping yet). (Closed)

Created:
8 years, 9 months ago by SeRya
Modified:
8 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

Dragging files (not dropping yet). BUG=chromium-os:20162 TEST=Manual test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128905

Patch Set 1 #

Total comments: 16

Patch Set 2 : Code review fixes. #

Total comments: 3

Patch Set 3 : Code review fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -62 lines) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 4 chunks +38 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 2 15 chunks +125 lines, -62 lines 0 comments Download
M chrome/browser/resources/file_manager/main.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
SeRya
8 years, 9 months ago (2012-03-26 12:55:26 UTC) #1
dgozman
https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resources/file_manager/css/file_manager.css File chrome/browser/resources/file_manager/css/file_manager.css (right): https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resources/file_manager/css/file_manager.css#newcode1103 chrome/browser/resources/file_manager/css/file_manager.css:1103: /* Only nodes in visiblt viewport will be rendered. ...
8 years, 9 months ago (2012-03-26 13:10:22 UTC) #2
SeRya
https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resources/file_manager/css/file_manager.css File chrome/browser/resources/file_manager/css/file_manager.css (right): https://chromiumcodereview.appspot.com/9856014/diff/1/chrome/browser/resources/file_manager/css/file_manager.css#newcode1103 chrome/browser/resources/file_manager/css/file_manager.css:1103: /* Only nodes in visiblt viewport will be rendered. ...
8 years, 9 months ago (2012-03-26 13:37:45 UTC) #3
dgozman
https://chromiumcodereview.appspot.com/9856014/diff/6001/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/9856014/diff/6001/chrome/browser/resources/file_manager/js/file_manager.js#newcode2197 chrome/browser/resources/file_manager/js/file_manager.js:2197: entry.file(function(f) { 1. This should not be done on ...
8 years, 9 months ago (2012-03-26 13:50:45 UTC) #4
SeRya
https://chromiumcodereview.appspot.com/9856014/diff/6001/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/9856014/diff/6001/chrome/browser/resources/file_manager/js/file_manager.js#newcode2197 chrome/browser/resources/file_manager/js/file_manager.js:2197: entry.file(function(f) { On 2012/03/26 13:50:45, dgozman wrote: > 1. ...
8 years, 9 months ago (2012-03-26 14:00:17 UTC) #5
dgozman
8 years, 9 months ago (2012-03-26 14:14:47 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698