Replace size_t with int in a few media classes.

media/base/data_source.h

Index: media/base/data_source.h
diff --git a/media/base/data_source.h b/media/base/data_source.h
index 75772373ed7f5b8f84f3d7c4d7522dd8437f11c1..2c7e80835b1312d81faf4fe3bd4969c173131ed9 100644
--- a/media/base/data_source.h
+++ b/media/base/data_source.h
@@ -30,8 +30,8 @@ class MEDIA_EXPORT DataSourceHost {
 class MEDIA_EXPORT DataSource : public base::RefCountedThreadSafe<DataSource> {
  public:
   typedef base::Callback<void(int64, int64)> StatusCallback;
-  typedef base::Callback<void(size_t)> ReadCB;
-  static const size_t kReadError;
+  typedef base::Callback<void(int)> ReadCB;
+  static const int kReadError;
 
   DataSource();
 
@@ -40,10 +40,7 @@ class MEDIA_EXPORT DataSource : public base::RefCountedThreadSafe<DataSource> {
   // Reads |size| bytes from |position| into |data|. And when the read is done
   // or failed, |read_cb| is called with the number of bytes read or
   // kReadError in case of error.
-  // TODO(hclam): should change |size| to int! It makes the code so messy
-  // with size_t and int all over the place..
-  virtual void Read(int64 position, size_t size,
-                    uint8* data,
+  virtual void Read(int64 position, int size, uint8* data,

[Ami GONE FROM CHROMIUM, 2012/03/26 23:01:20]

Shouldn't |position| be int, too?

Generally my only worry about this CL is overflowing 32-bit signed int.  The
only way I can think of that *might* do that is playing a large local file and
getting it all to try to squeeze into a Buffer.  Have you verified that this
doesn't break local >2G files?

[scherkus (not reviewing), 2012/03/26 23:19:39]

We do <32-bit reads on >32-bit resources hence the int64 position, but int size.
Testing variety of >2G files and all is good. In general our reads are on the
order of ~32kb (FFmpeg's default bitstream parser read size).

                     const DataSource::ReadCB& read_cb) = 0;
 
   // Notifies the DataSource of a change in the current playback rate.