Replace size_t with int in a few media classes.

media/base/data_source.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_DATA_SOURCE_H_
 #define MEDIA_BASE_DATA_SOURCE_H_
 
 #include "base/callback.h"
 #include "base/memory/ref_counted.h"
 #include "media/base/media_export.h"
@@ skipping 12 matching lines @@
   // be played.
   virtual void SetBufferedBytes(int64 buffered_bytes) = 0;
 
   // Sets the flag to indicate current network activity.
   virtual void SetNetworkActivity(bool is_downloading_data) = 0;
 };
 
 class MEDIA_EXPORT DataSource : public base::RefCountedThreadSafe<DataSource> {
  public:
   typedef base::Callback<void(int64, int64)> StatusCallback;
-  typedef base::Callback<void(size_t)> ReadCB;
-  static const size_t kReadError;
+  typedef base::Callback<void(int)> ReadCB;
+  static const int kReadError;
 
   DataSource();
 
   virtual void set_host(DataSourceHost* host);
 
   // Reads |size| bytes from |position| into |data|. And when the read is done
   // or failed, |read_cb| is called with the number of bytes read or
   // kReadError in case of error.
-  // TODO(hclam): should change |size| to int! It makes the code so messy
-  // with size_t and int all over the place..
-  virtual void Read(int64 position, size_t size,
-                    uint8* data,
+  virtual void Read(int64 position, int size, uint8* data,

[Ami GONE FROM CHROMIUM, 2012/03/26 23:01:20]

Shouldn't |position| be int, too?

Generally my only worry about this CL is overflowing 32-bit signed int.  The
only way I can think of that *might* do that is playing a large local file and
getting it all to try to squeeze into a Buffer.  Have you verified that this
doesn't break local >2G files?

[scherkus (not reviewing), 2012/03/26 23:19:39]

We do <32-bit reads on >32-bit resources hence the int64 position, but int size.
Testing variety of >2G files and all is good. In general our reads are on the
order of ~32kb (FFmpeg's default bitstream parser read size).

                     const DataSource::ReadCB& read_cb) = 0;
 
   // Notifies the DataSource of a change in the current playback rate.
   virtual void SetPlaybackRate(float playback_rate);
 
   // Stops the DataSource. Once this is called all future Read() calls will
   // return an error.
   virtual void Stop(const base::Closure& callback) = 0;
 
   // Returns true and the file size, false if the file size could not be
@@ skipping 20 matching lines @@
 
  private:
   DataSourceHost* host_;
 
   DISALLOW_COPY_AND_ASSIGN(DataSource);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_DATA_SOURCE_H_