Improve checked mode a little (more to come in a different CL).

runtime/vm/opt_code_generator_ia32.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/opt_code_generator.h"
 
 #include "vm/assembler_macros.h"
@@ skipping 1325 matching lines @@
     __ Bind(&done);
     HandleResult(node, EAX);
   }
 }
 
 
 void OptimizingCodeGenerator::VisitBinaryOpNode(BinaryOpNode* node) {
   // Operators "&&" and "||" cannot be overloaded, therefore inline them
   // instead of calling the operator.
   if ((node->kind() == Token::kAND) || (node->kind() == Token::kOR)) {
+    // TODO(srdjan): Test in checked mode if they are Booleans otherwise
+    // throw exception.
     if (FLAG_enable_type_checks) {
       CodeGenerator::VisitBinaryOpNode(node);
       return;
     }
     GenerateLogicalBinaryOp(node);
     return;
   }
 
   const ICData& ic_data = node->ICDataAtId(node->id());
   if (ic_data.NumberOfChecks() == 0) {
@@ skipping 47 matching lines @@
                                node->left(),
                                node->id(),
                                node->token_index(),
                                number_of_arguments,
                                no_optional_argument_names);
   HandleResult(node, EAX);
   return;
 }
 
 
+// Optimized for Smi only.
 void OptimizingCodeGenerator::VisitIncrOpLocalNode(IncrOpLocalNode* node) {
   if (FLAG_enable_type_checks) {
-    classes_for_locals_->SetLocalType(node->local(), Class::ZoneHandle());
-    CodeGenerator::VisitIncrOpLocalNode(node);
-    return;
+    const AbstractType& local_type = node->local().type();
+    if (!local_type.IsNumberInterface() && !local_type.IsIntInterface()) {
+      // Local does not accept a Smi (only Smi's interfaces are public).
+      classes_for_locals_->SetLocalType(node->local(), Class::ZoneHandle());
+      CodeGenerator::VisitIncrOpLocalNode(node);
+      return;
+    }
   }
   const ICData& ic_data = node->ICDataAtId(node->id());
   if (ic_data.NumberOfChecks() == 0) {
     DeoptimizationBlob* deopt_blob =
         AddDeoptimizationBlob(node, kDeoptNoTypeFeedback);
     __ jmp(deopt_blob->label());
     return;
   }
   const char* kOptMessage = "Inlines IncrOpLocal";
   ASSERT((node->kind() == Token::kINCR) || (node->kind() == Token::kDECR));
@@ skipping 1681 matching lines @@
 
 
 void OptimizingCodeGenerator::VisitTryCatchNode(TryCatchNode* node) {
   // TODO(srdjan): Set classes for locals.
   classes_for_locals_->Clear();
   CodeGenerator::VisitTryCatchNode(node);
 }
 
 
 void OptimizingCodeGenerator::VisitUnaryOpNode(UnaryOpNode* node) {
-  if (FLAG_enable_type_checks) {
+  // TODO(srdjan): Test in checked mode if value is Boolean, throw error
+  // otherwise.
+  if (FLAG_enable_type_checks && node->kind() == Token::kNOT) {
     CodeGenerator::VisitUnaryOpNode(node);
     return;
   }
   // TODO(srdjan): Jump directly to labels instead of returning a boolean.
   if (node->kind() == Token::kNOT) {
     // Only a true bool returns false, everything else is true.
     CodeGenInfo info(node->operand());
     VisitLoadOne(node->operand(), EDX);
     Label done;
     __ LoadObject(EAX, Bool::ZoneHandle(Bool::True()));
@@ skipping 22 matching lines @@
     }
   }
   // TODO(srdjan): Implement unary kSUB (negate) Mint.
   CodeGenerator::VisitUnaryOpNode(node);
 }
 
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32