Handle broken artwork icons in Chrome OS Media Player

chrome/browser/resources/file_manager/js/media/audio_player.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 document.addEventListener('DOMContentLoaded', function() {
   // Test harness sets the search string to prevent the automatic load.
   // It calls AudioPlayer.load() explicitly after initializing
   // the |chrome| variable with an appropriate mock object.
   if (!document.location.search) {
     AudioPlayer.load();
@@ skipping 105 matching lines @@
       this.loadMetadata_(i);
   }
 };
 
 AudioPlayer.prototype.loadMetadata_ = function(track) {
   this.fetchMetadata_(
       this.urls_[track], this.displayMetadata_.bind(this, track));
 };
 
 AudioPlayer.prototype.displayMetadata_ = function(track, metadata) {
-  if (metadata.thumbnailURL || metadata.error) {
-    this.container_.classList.remove('noart');
-  }
-  this.trackListItems_[track].setMetadata(metadata);
-  this.trackStackItems_[track].setMetadata(metadata);
+  this.trackListItems_[track].setMetadata(metadata, this.container_);
+  this.trackStackItems_[track].setMetadata(metadata, this.container_);
 };
 
 AudioPlayer.prototype.select_ = function(newTrack) {
   if (this.currentTrack_ == newTrack) return;
 
   this.changeSelectionInList_(this.currentTrack_, newTrack);
   this.changeSelectionInStack_(this.currentTrack_, newTrack);
 
   this.currentTrack_ = newTrack;
   this.scrollToCurrent_(false);
@@ skipping 98 matching lines @@
         this.advance_(true /* forward */, true /* only if valid */);
       }.bind(this),
       3000);
 };
 
 AudioPlayer.prototype.cancelAutoAdvance_ = function() {
   if (this.autoAdvanceTimer_) {
     clearTimeout(this.autoAdvanceTimer_);
     this.autoAdvanceTimer_ = null;
   }
-}
+};
 
 AudioPlayer.prototype.onExpandCollapse_ = function() {
   this.container_.classList.toggle('collapsed');
   this.syncHeight_();
   if (!this.isCompact_())
     this.scrollToCurrent_(true);
 };
 
 /* Keep the below constants in sync with the CSS. */
 // TODO(kaznacheev): Set to 30 when the audio player is title-less.
@@ skipping 58 matching lines @@
   var title = this.url_.split('/').pop();
   var dotIndex = title.lastIndexOf('.');
   if (dotIndex >= 0) title = title.substr(0, dotIndex);
   return title;
 };
 
 AudioPlayer.TrackInfo.prototype.getDefaultArtist = function() {
   return 'Unknown Artist';  // TODO(kaznacheev): i18n
 };
 
-AudioPlayer.TrackInfo.prototype.setMetadata = function(metadata) {
+/**
+ * @param {Object} metadata The metadata object
+ * @param {HTMLElement} container The container for the tracks.
+ */
+AudioPlayer.TrackInfo.prototype.setMetadata = function(metadata, container) {
   if (metadata.error) {
     this.art_.classList.add('blank');
     this.art_.classList.add('error');
+    container.classList.remove('noart');
   } else if (metadata.thumbnailURL) {
-    this.art_.classList.remove('blank');
+    this.img_.onload = function() {
+      // Only display the image if the thumbnail

[dgozman, 2012/03/26 10:52:49]

Incomplete phrase?

[Vladislav Kaznacheev, 2012/03/26 10:55:52]

Done.

+      this.art_.classList.remove('blank');
+      container.classList.remove('noart');
+    }.bind(this);
     this.img_.src = metadata.thumbnailURL;
   }
   this.title_.textContent = metadata.title || this.getDefaultTitle();
   this.artist_.textContent = metadata.artist || this.getDefaultArtist();
 };