Normalize download file name on chromeos

chrome/browser/download/chrome_download_manager_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/chrome_download_manager_delegate.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 410 matching lines @@
 
   // Check whether this download is for an extension install or not.
   // Allow extensions to be explicitly saved.
   DownloadStateInfo state = download->GetStateInfo();
 
   if (state.force_file_name.empty()) {
     FilePath generated_name;
     download_util::GenerateFileNameFromRequest(*download,
                                                &generated_name);
 
+#if defined(OS_CHROMEOS)
+    // When doing file manager operations on ChromeOS, the file paths get
+    // normalized in WebKit layer, so let's ensure downloaded files have
+    // normalized names. Otherwise, we won't be able to handle files with NFD
+    // utf8 encoded characters in name.
+    download_util::NormalizeFileNameOnChromeOS(&generated_name);

[asanka, 2012/03/26 20:01:08]

why not do this in download_util::GenerateFileNameFromRequest() or better yet,
net::GetSuggestedFilename() ?

[tbarzic, 2012/03/26 20:59:50]

Done.

+#endif
+
     // Freeze the user's preference for showing a Save As dialog.  We're going
     // to bounce around a bunch of threads and we don't want to worry about race
     // conditions where the user changes this pref out from under us.
     if (download_prefs_->PromptForDownload()) {
       // But ignore the user's preference for the following scenarios:
       // 1) Extension installation. Note that we only care here about the case
       //    where an extension is installed, not when one is downloaded with
       //    "save as...".
       // 2) Filetypes marked "always open." If the user just wants this file
       //    opened, don't bother asking where to keep it.
@@ skipping 193 matching lines @@
     int32 download_id, int64 db_handle) {
   // It's not immediately obvious, but HistoryBackend::CreateDownload() can
   // call this function with an invalid |db_handle|. For instance, this can
   // happen when the history database is offline. We cannot have multiple
   // DownloadItems with the same invalid db_handle, so we need to assign a
   // unique |db_handle| here.
   if (db_handle == DownloadItem::kUninitializedHandle)
     db_handle = download_history_->GetNextFakeDbHandle();
   download_manager_->OnItemAddedToPersistentStore(download_id, db_handle);
 }