extensions/browser/guest_view/web_view/web_view_permission_helper.cc - Issue 984963004: <webview>: Implement fullscreen permission for html5 element.requestFullscreen()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_permission_helper.cc

Issue 984963004: <webview>: Implement fullscreen permission for html5 element.requestFullscreen() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tmptmptmp

Patch Set: Disable one test one test on mac with bug ref, use document.webkitIsFullScreen Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_guest.cc ('k') | extensions/browser/guest_view/web_view/web_view_permission_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_permission_helper.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_permission_helper.cc b/extensions/browser/guest_view/web_view/web_view_permission_helper.cc

index c67042ed26e971244edcca1b01dd024ba71b68a6..2b1570a4a4a6e9d4a59852b3d796305dd1e0c21a 100644

--- a/extensions/browser/guest_view/web_view/web_view_permission_helper.cc

+++ b/extensions/browser/guest_view/web_view/web_view_permission_helper.cc

@@ -25,6 +25,8 @@ static std::string PermissionTypeToString(WebViewPermissionType type) {

return webview::kPermissionTypeDownload;

case WEB_VIEW_PERMISSION_TYPE_FILESYSTEM:

return webview::kPermissionTypeFileSystem;

+ case WEB_VIEW_PERMISSION_TYPE_FULLSCREEN:

+ return webview::kPermissionTypeFullscreen;

case WEB_VIEW_PERMISSION_TYPE_GEOLOCATION:

return webview::kPermissionTypeGeolocation;

case WEB_VIEW_PERMISSION_TYPE_JAVASCRIPT_DIALOG:

@@ -61,6 +63,10 @@ void RecordUserInitiatedUMA(

content::RecordAction(

UserMetricsAction("WebView.PermissionAllow.FileSystem"));

break;

+ case WEB_VIEW_PERMISSION_TYPE_FULLSCREEN:

+ content::RecordAction(

+ UserMetricsAction("WebView.PermissionAllow.Fullscreen"));

+ break;

case WEB_VIEW_PERMISSION_TYPE_GEOLOCATION:

content::RecordAction(

UserMetricsAction("WebView.PermissionAllow.Geolocation"));

@@ -97,6 +103,10 @@ void RecordUserInitiatedUMA(

content::RecordAction(

UserMetricsAction("WebView.PermissionDeny.FileSystem"));

break;

+ case WEB_VIEW_PERMISSION_TYPE_FULLSCREEN:

+ content::RecordAction(

+ UserMetricsAction("WebView.PermissionDeny.Fullscreen"));

+ break;

case WEB_VIEW_PERMISSION_TYPE_GEOLOCATION:

content::RecordAction(

UserMetricsAction("WebView.PermissionDeny.Geolocation"));