extensions/browser/guest_view/web_view/web_view_constants.cc - Issue 984963004: <webview>: Implement fullscreen permission for html5 element.requestFullscreen()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_constants.cc

Issue 984963004: <webview>: Implement fullscreen permission for html5 element.requestFullscreen() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tmptmptmp

Patch Set: Disable one test one test on mac with bug ref, use document.webkitIsFullScreen Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/guest_view/web_view/web_view_constants.h ('k') | extensions/browser/guest_view/web_view/web_view_guest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/web_view/web_view_constants.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_constants.cc b/extensions/browser/guest_view/web_view/web_view_constants.cc

index bb11d9ce243a28e3e3129304ea3d6e54a305cdd3..7502e6e70455943a797bb1ba61d4e5bf290e2fa0 100644

--- a/extensions/browser/guest_view/web_view/web_view_constants.cc

+++ b/extensions/browser/guest_view/web_view/web_view_constants.cc

@@ -28,6 +28,7 @@ const char kEventContextMenu[] = "chromeWebViewInternal.contextmenu";

const char kEventDialog[] = "webViewInternal.onDialog";

const char kEventDropLink[] = "webViewInternal.onDropLink";

const char kEventExit[] = "webViewInternal.onExit";

+const char kEventExitFullscreen[] = "webViewInternal.onExitFullscreen";

const char kEventFindReply[] = "webViewInternal.onFindReply";

const char kEventFrameNameChanged[] = "webViewInternal.onFrameNameChanged";

const char kEventLoadAbort[] = "webViewInternal.onLoadAbort";

@@ -66,10 +67,12 @@ const char kNewURL[] = "newUrl";

const char kNewWidth[] = "newWidth";

const char kOldHeight[] = "oldHeight";

const char kOldURL[] = "oldUrl";

+const char kOrigin[] = "origin";

const char kPermission[] = "permission";

const char kPermissionTypeDialog[] = "dialog";

const char kPermissionTypeDownload[] = "download";

const char kPermissionTypeFileSystem[] = "filesystem";

+const char kPermissionTypeFullscreen[] = "fullscreen";

const char kPermissionTypeGeolocation[] = "geolocation";

const char kPermissionTypeLoadPlugin[] = "loadplugin";

const char kPermissionTypeMedia[] = "media";