Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: extensions/browser/guest_view/guest_view_base.h

Issue 984963004: <webview>: Implement fullscreen permission for html5 element.requestFullscreen() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tmptmptmp
Patch Set: Disable one test one test on mac with bug ref, use document.webkitIsFullScreen Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/guest_view_base.h
diff --git a/extensions/browser/guest_view/guest_view_base.h b/extensions/browser/guest_view/guest_view_base.h
index 231275f9cc1a7b499edb2cdb5494611222914e7a..549fa1ea61c7145459217d4e2c894e976e7c2cc6 100644
--- a/extensions/browser/guest_view/guest_view_base.h
+++ b/extensions/browser/guest_view/guest_view_base.h
@@ -124,6 +124,12 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
// work.
virtual void GuestReady() {}
+ // This method is called when embedder WebContents's fullscreen is toggled.
+ //
+ // If the guest asked the embedder to enter fullscreen, the guest uses this
+ // signal to exit fullscreen state.
+ virtual void EmbedderFullscreenToggled(bool entered_fullscreen) {}
+
// This method is invoked when the contents auto-resized to give the container
// an opportunity to match it if it wishes.
//
@@ -347,7 +353,7 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
void UpdateTargetURL(content::WebContents* source, const GURL& url) override;
private:
- class OwnerLifetimeObserver;
+ class OwnerContentsObserver;
class OpenerLifetimeObserver;
@@ -414,7 +420,7 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,
// This observer ensures that this guest self-destructs if the embedder goes
// away.
- scoped_ptr<OwnerLifetimeObserver> owner_lifetime_observer_;
+ scoped_ptr<OwnerContentsObserver> owner_contents_observer_;
// This observer ensures that if the guest is unattached and its opener goes
// away then this guest also self-destructs.

Powered by Google App Engine
This is Rietveld 408576698