Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1636)

Unified Diff: annotated_steps.py

Issue 984743002: Update annotated steps to run tests with a valid package-root (Closed) Base URL: git@github.com:dart-lang/package-bots.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: annotated_steps.py
diff --git a/annotated_steps.py b/annotated_steps.py
index 222e3fbceb2d88626a3df1ae919f2de7cf379e65..11fc9ba1745c0f2afb3d523970ea01464c80c81d 100755
--- a/annotated_steps.py
+++ b/annotated_steps.py
@@ -302,14 +302,16 @@ JS_RUNTIMES = {
'mac': ['safari'],
}
-def RunPackageTesting(bot_info, package_path):
- package_root = os.path.join(package_path, 'packages')
+def RunPackageTesting(bot_info, package_path, folder='test/'):
+ package_name = os.path.basename(os.path.dirname(package_path))
+ package_root = os.path.join(package_path, folder, 'packages')
Siggi Cherem (dart-lang) 2015/03/05 22:01:47 this ensures that we are using the transformed pac
standard_args = ['--suite-dir=%s' % package_path,
'--use-sdk', '--report', '--progress=buildbot',
'--clear_browser_cache',
'--package-root=%s' % package_root,
'--write-debug-log', '-v',
- '--time']
+ '--time',
+ '%s/%s/%s/' % (package_name, package_name, folder)]
system = bot_info.system
xvfb_command = ['xvfb-run', '-a', '--server-args=-screen 0 1024x768x24']
xvfb_args = xvfb_command if system == 'linux' else []
@@ -369,5 +371,6 @@ if __name__ == '__main__':
FixupTestControllerJS(copy_path)
RunPreTestHooks(test_config)
- RunPackageTesting(bot_info, copy_path)
+ RunPackageTesting(bot_info, copy_path, 'test')
+ RunPackageTesting(bot_info, copy_path, 'build/test/')
jakemac 2015/03/05 21:59:30 these should either both have a trailing slash or
Siggi Cherem (dart-lang) 2015/03/05 22:01:47 Done :)
RunPostTestHooks(test_config)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698