Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 984743002: Update annotated steps to run tests with a valid package-root (Closed)

Created:
5 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 9 months ago
Reviewers:
ricow1, jakemac
Base URL:
git@github.com:dart-lang/package-bots.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update annotated steps to run tests with a valid package-root R=jakemac@google.com Committed: https://github.com/dart-lang/packages-bots/commit/c2859937f6218fed123fba7dec6ad7a35910cbf1

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M annotated_steps.py View 1 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-05 21:58:05 UTC) #2
jakemac
https://chromiumcodereview.appspot.com/984743002/diff/1/annotated_steps.py File annotated_steps.py (right): https://chromiumcodereview.appspot.com/984743002/diff/1/annotated_steps.py#newcode375 annotated_steps.py:375: RunPackageTesting(bot_info, copy_path, 'build/test/') these should either both have a ...
5 years, 9 months ago (2015-03-05 21:59:30 UTC) #3
jakemac
lgtm
5 years, 9 months ago (2015-03-05 21:59:34 UTC) #4
Siggi Cherem (dart-lang)
thanks! https://chromiumcodereview.appspot.com/984743002/diff/1/annotated_steps.py File annotated_steps.py (right): https://chromiumcodereview.appspot.com/984743002/diff/1/annotated_steps.py#newcode307 annotated_steps.py:307: package_root = os.path.join(package_path, folder, 'packages') this ensures that ...
5 years, 9 months ago (2015-03-05 22:01:47 UTC) #5
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-05 22:01:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c2859937f6218fed123fba7dec6ad7a35910cbf1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698