Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4059)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 98463005: Enable/disable extensions upon changes in blacklist. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Show blacklist state together with location. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index 1fd9ecd4af8ee24738a363aac5966e8c31d889ae..d7979a376e61789fd7692b59bb8b151eec727134 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -69,6 +69,7 @@
#include "content/public/browser/web_contents_view.h"
#include "content/public/browser/web_ui.h"
#include "content/public/browser/web_ui_data_source.h"
+#include "extensions/browser/blacklist_state.h"
#include "extensions/browser/extension_error.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/lazy_background_task_queue.h"
@@ -256,6 +257,29 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
}
extension_data->SetString("locationText", location_text);
+ base::string16 blacklist_text;
+ switch (extension_service_->extension_prefs()->GetExtensionBlacklistState(
+ extension->id())) {
+ case BLACKLISTED_SECURITY_VULNERABILITY:
+ blacklist_text = l10n_util::GetStringUTF16(
+ IDS_OPTIONS_BLACKLISTED_SECURITY_VULNERABILITY);
+ break;
+
+ case BLACKLISTED_CWS_POLICY_VIOLATION:
+ blacklist_text = l10n_util::GetStringUTF16(
+ IDS_OPTIONS_BLACKLISTED_CWS_POLICY_VIOLATION);
+ break;
+
+ case BLACKLISTED_POTENTIALLY_UNWANTED:
+ blacklist_text = l10n_util::GetStringUTF16(
+ IDS_OPTIONS_BLACKLISTED_POTENTIALLY_UNWANTED);
+ break;
+
+ default:
+ break;
+ }
+ extension_data->SetString("blacklistText", blacklist_text);
+
// Force unpacked extensions to show at the top.
if (Manifest::IsUnpackedLocation(extension->location()))
extension_data->SetInteger("order", 1);

Powered by Google App Engine
This is Rietveld 408576698