Enable/disable extensions upon changes in blacklist.

chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index 1fd9ecd4af8ee24738a363aac5966e8c31d889ae..42ab58de446b8c44155da6d23bc1354ff0ef5926 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -69,6 +69,7 @@
 #include "content/public/browser/web_contents_view.h"
 #include "content/public/browser/web_ui.h"
 #include "content/public/browser/web_ui_data_source.h"
+#include "extensions/browser/blacklist_state.h"
 #include "extensions/browser/extension_error.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/lazy_background_task_queue.h"
@@ -242,6 +243,9 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
   extension_data->SetBoolean("homepageProvided",
       ManifestURL::GetHomepageURL(extension).is_valid());
 
+  BlacklistState blacklist_state =
+      extension_service_->extension_prefs()->GetExtensionBlacklistState(
+          extension->id());
   base::string16 location_text;
   if (Manifest::IsPolicyLocation(extension->location())) {
     location_text = l10n_util::GetStringUTF16(
@@ -253,6 +257,26 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
   } else if (extension->location() == Manifest::EXTERNAL_REGISTRY) {
     location_text = l10n_util::GetStringUTF16(
         IDS_OPTIONS_INSTALL_LOCATION_3RD_PARTY);
+  } else if (blacklist_state != NOT_BLACKLISTED) {

[Finnur, 2014/01/23 15:21:38]

It is a bit weird that we'd categorize this label lower in priority than the one
for policy-extensions, the one for internal-but-not-from-webstore-extensions and
for registry-extensions. 

But lets take a step back. With the blacklist label this is really not an
either-or kind of situation anymore, like |location| is. It is not a stretch to
imagine us blacklisting one of the types of extensions that the if clauses (on
line 250-259 above) cover. We'd never see the blacklist label in that case,
which doesn't seem right.

This label should, in my mind be separate and added right after the location
based one.

[Oleg Eterevsky, 2014/01/23 16:33:06]

I'll ask a PM working on this feature to find the right people to decide what
should happen if these two states coincide. In my opinion, this shouldn't really
happen, and we should just show the more important message.

+    switch (blacklist_state) {
+      case BLACKLISTED_SECURITY_VULNERABILITY:
+        location_text = l10n_util::GetStringUTF16(
+            IDS_OPTIONS_BLACKLISTED_SECURITY_VULNERABILITY);
+        break;
+
+      case BLACKLISTED_CWS_POLICY_VIOLATION:
+        location_text = l10n_util::GetStringUTF16(
+            IDS_OPTIONS_BLACKLISTED_CWS_POLICY_VIOLATION);
+        break;
+
+      case BLACKLISTED_POTENTIALLY_UNWANTED:
+        location_text = l10n_util::GetStringUTF16(
+            IDS_OPTIONS_BLACKLISTED_POTENTIALLY_UNWANTED);
+        break;

[Finnur, 2014/01/23 15:21:38]

Why is BLACKLISTED_MALWARE not handled?

[Oleg Eterevsky, 2014/01/23 16:33:06]

Because malware extensions are not shown in the list at all. We do not even have
a string for them.

+
+      default:
+        break;
+    }
   }
   extension_data->SetString("locationText", location_text);