chrome/browser/resources/extensions/extensions.html - Issue 98463005: Enable/disable extensions upon changes in blacklist.

Side by Side Diff: chrome/browser/resources/extensions/extensions.html

Issue 98463005: Enable/disable extensions upon changes in blacklist. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Show blacklist state together with location. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html i18n-values="dir:textdirection;" class="loading">	2 <html i18n-values="dir:textdirection;" class="loading">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5	5

6 <link rel="stylesheet" href="extensions.css">	6 <link rel="stylesheet" href="extensions.css">

7 <link rel="stylesheet" href="extension_commands_overlay.css">	7 <link rel="stylesheet" href="extension_commands_overlay.css">

8 <link rel="stylesheet" href="extension_error.css">	8 <link rel="stylesheet" href="extension_error.css">

9 <link rel="stylesheet" href="extension_error_overlay.css">	9 <link rel="stylesheet" href="extension_error_overlay.css">

10 <link rel="stylesheet" href="pack_extension_overlay.css">	10 <link rel="stylesheet" href="pack_extension_overlay.css">

(...skipping 109 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
120 <span class="extension-version"></span>	120 <span class="extension-version"></span>

121 </div>	121 </div>

122 <p class="extension-description">	122 <p class="extension-description">

123 <span></span>	123 <span></span>

124 <a class="permissions-link"	124 <a class="permissions-link"

125 i18n-content="extensionSettingsPermissions"	125 i18n-content="extensionSettingsPermissions"

126 href="#">	126 href="#">

127 </a>	127 </a>

128 <a class="site-link" target="_parent" hidden></a>	128 <a class="site-link" target="_parent" hidden></a>

129 </p>	129 </p>

130 <div class="permanent-warnings">	130 <div class="permanent-warnings">
	Finnur 2014/01/27 13:15:04 Looking at the screenshot (thank you for that), I Looking at the screenshot (thank you for that), I realize we should not be adding the text under \|location\|. That space is too narrow for this much text and the error you are showing, which is pretty significant, does not get enough attention. I think you should instead add your message here, and do it in the same way as we do below, with the two child divs that start out hidden. This will look much better on screen and draw the user's attention to it immediately. Oleg Eterevsky 2014/01/27 13:59:58 I believe the UX for disable list message was conf Show quoted text On 2014/01/27 13:15:04, Finnur wrote: > Looking at the screenshot (thank you for that), I realize we should not be > adding the text under \|location\|. That space is too narrow for this much text > and the error you are showing, which is pretty significant, does not get enough > attention. > > I think you should instead add your message here, and do it in the same way as > we do below, with the two child divs that start out hidden. This will look much > better on screen and draw the user's attention to it immediately. I believe the UX for disable list message was confirmed by UX team. This message is not really a warning. It is more of a notice to explain to user why we have disabled this extension. Do you think it would be ok to commit this feature as is, so that it could start being tested, and then ask around about which form of this message is better?
131 <div class="extension-warnings" hidden>	131 <div class="extension-warnings" hidden>

132 <span i18n-content="extensionSettingsWarningsTitle"></span>	132 <span i18n-content="extensionSettingsWarningsTitle"></span>

133 <ul></ul>	133 <ul></ul>

134 </div>	134 </div>

135 <div class="suspicious-install-message" hidden>	135 <div class="suspicious-install-message" hidden>
	Finnur 2014/01/27 13:15:04 Please note that this div is very similar in natur Please note that this div is very similar in nature to your div showing very similar text. It is shown when an extension has been wiped (disabled) for being suspicious (to simulate it you can disable an extension and set the DisableReason for it in the prefs to 256 and then you'll see this div). This does make me wonder if we'll have any unfortunate overlap with what Antony has been doing (disabling non-cws extensions). CC-ing Antony, to keep him in the loop. Oleg Eterevsky 2014/01/27 13:59:58 Thanks. We met Antony a while ago and he should be Show quoted text On 2014/01/27 13:15:04, Finnur wrote: > Please note that this div is very similar in nature to your div showing very > similar text. It is shown when an extension has been wiped (disabled) for being > suspicious (to simulate it you can disable an extension and set the > DisableReason for it in the prefs to 256 and then you'll see this div). > > This does make me wonder if we'll have any unfortunate overlap with what Antony > has been doing (disabling non-cws extensions). CC-ing Antony, to keep him in the > loop. Thanks. We met Antony a while ago and he should be aware of this feature.
136 <span i18n-content="extensionSettingsSuspiciousInstall"></span>	136 <span i18n-content="extensionSettingsSuspiciousInstall"></span>

137 <a target="_blank" class="learn-more-link"	137 <a target="_blank" class="learn-more-link"

138 i18n-values="href:extensionSettingsSuspiciousInstallHelpUrl"	138 i18n-values="href:extensionSettingsSuspiciousInstallHelpUrl"

139 i18n-content="extensionSettingsSuspiciousInstallLearnMore"	139 i18n-content="extensionSettingsSuspiciousInstallLearnMore"

140 href="#">	140 href="#">

141 </a>	141 </a>

142 </div>	142 </div>

143 </div>	143 </div>

144 <div class="developer-extras">	144 <div class="developer-extras">

145 <div>	145 <div>

(...skipping 49 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
195 <div class="checkbox enable-checkbox" hidden><label>	195 <div class="checkbox enable-checkbox" hidden><label>

196 <input type="checkbox">	196 <input type="checkbox">

197 <span class="enable-checkbox-text">	197 <span class="enable-checkbox-text">

198 <span class="enabled-text" i18n-content="extensionSettingsEnabled">	198 <span class="enabled-text" i18n-content="extensionSettingsEnabled">

199 </span>	199 </span>

200 <span class="enable-text" i18n-content="extensionSettingsEnable">	200 <span class="enable-text" i18n-content="extensionSettingsEnable">

201 </span>	201 </span>

202 </span>	202 </span>

203 </label>	203 </label>

204 <span class="location-text"></span>	204 <span class="location-text"></span>

	205 <span class="blacklist-text"></span>

205 </div>	206 </div>

206 </div>	207 </div>

207 </div>	208 </div>

208 </div>	209 </div>

209	210

210 <include src="../../../../ui/webui/resources/html/trash.html">	211 <include src="../../../../ui/webui/resources/html/trash.html">

211 <include src="extension_error.html">	212 <include src="extension_error.html">

212	213

213 </div>	214 </div>

214	215

215 <script src="chrome://extensions-frame/strings.js"></script>	216 <script src="chrome://extensions-frame/strings.js"></script>

216 <script src="chrome://resources/js/i18n_template2.js"></script>	217 <script src="chrome://resources/js/i18n_template2.js"></script>

217	218

218 </body>	219 </body>

219 </html>	220 </html>

OLD	NEW