Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: runtime/bin/builtin.dart

Issue 9845040: - Make the URI resolution methods used by the tag handler private. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/builtin.dart
===================================================================
--- runtime/bin/builtin.dart (revision 5791)
+++ runtime/bin/builtin.dart (working copy)
@@ -35,7 +35,7 @@
}
// TODO(iposva): Make these private once the Dart API is fixed.
srdjan 2012/03/23 22:48:46 Remove TODO
Ivan Posva 2012/03/28 01:20:31 Done.
-String resolveScriptUri(String cwd, String scriptName, bool windows) {
+String _resolveScriptUri(String cwd, String scriptName, bool windows) {
_is_windows = windows;
_logResolution("# Current working directory: $cwd");
_logResolution("# ScriptName: $scriptName");
@@ -60,7 +60,7 @@
return resolved.toString();
}
-String resolveUri(String base, String userString) {
+String _resolveUri(String base, String userString) {
var baseUri = new Uri.fromString(base);
_logResolution("# Resolving: $userString from $base");
var resolved = baseUri.resolve(userString);
@@ -68,7 +68,7 @@
return resolved.toString();
}
-String resolveExtensionUri(String base, String userString) {
+String _resolveExtensionUri(String base, String userString) {
var uri = new Uri.fromString(userString);
if ("dart-ext" != uri.scheme) {
throw "Not a Dart extension uri: $uri";
@@ -82,7 +82,7 @@
return resolved.toString();
}
-String filePathFromUri(String userUri) {
+String _filePathFromUri(String userUri) {
var uri = new Uri.fromString(userUri);
_logResolution("# Getting file path from: $uri");
if ("file" != uri.scheme) {
« no previous file with comments | « no previous file | runtime/bin/main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698