Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9845033: Move the MediaObserver getter from ResourceContext to ContentBrowserClient, since we only need to s… (Closed)

Created:
8 years, 9 months ago by jam
Modified:
8 years, 9 months ago
Reviewers:
Jói
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Move the MediaObserver getter from ResourceContext to ContentBrowserClient, since we only need to support one. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128789 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128819

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : reupload after revert #

Patch Set 5 : fix dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -124 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/io_thread.h View 1 2 3 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 2 3 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/media/media_internals.h View 1 2 3 4 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/media/media_internals.cc View 1 2 3 4 3 chunks +14 lines, -8 lines 0 comments Download
M chrome/browser/media/media_internals_unittest.cc View 1 2 3 4 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 3 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/media/media_internals_proxy.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/mock_content_browser_client.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/mock_content_browser_client.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.h View 1 2 3 2 chunks +3 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 2 3 11 chunks +20 lines, -31 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 1 2 3 4 chunks +4 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 2 3 3 chunks +5 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 2 chunks +7 lines, -2 lines 0 comments Download
M content/public/browser/media_observer.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/browser/resource_context.h View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M content/shell/shell_content_browser_client.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/shell_content_browser_client.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/shell_resource_context.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/shell_resource_context.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M content/test/mock_resource_context.h View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M content/test/mock_resource_context.cc View 1 2 3 2 chunks +2 lines, -8 lines 0 comments Download
M content/test/webrtc_audio_device_test.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
8 years, 9 months ago (2012-03-23 19:42:47 UTC) #1
Jói
LGTM, nice simplification.
8 years, 9 months ago (2012-03-23 20:07:16 UTC) #2
jam
8 years, 9 months ago (2012-03-23 20:49:38 UTC) #3 
On 2012/03/23 20:07:16, Jói wrote:
> LGTM, nice simplification.

btw I ran into a dcheck because now I was using the IOThread from the main
thread. I just made MediaInternals itself a singleton, instead of hanging off
the IOThread singleton which hangs off the BrowserProcessImpl singelton

Powered by Google App Engine
This is Rietveld 408576698