Fixes two type warnings in test_runner.dart

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 313 matching lines @@
     if (hasCrashed) return false;
 
     List<String> errors = [];
     List<String> staticWarnings = [];
 
     // Read the returned list of errors and stuff them away.
     for (String line in super.stderr) {
       if (line.length == 0) continue;
       List<String> fields = splitMachineError(line);
       if (fields[0] == 'ERROR') {
-        errors.add(fields);
+        errors.add(fields[7]);

[Bill Hesse, 2012/03/23 22:16:08]

Perhaps add a comment that the relevant data is in field 8?  Or add constants
for the field positions?

Why did this not cause failures?  Do we only ever use errors.length and
staticWarnings.length?

[zundel, 2012/03/24 01:06:39]

Added constants.

In the case of multitests, it looks like only the lengths are checked.  Still, I
want to put something meaningful in there.

       } else if (fields[0] == 'WARNING') {
         // We only care about testing Static type warnings
         // ignore all others
         if (fields[1] == 'STATIC_TYPE') {
-          staticWarnings.add(fields);
+          staticWarnings.add(fields[7]);
         }
       }
       // OK to Skip error output that doesn't match the machine format
     }
     if (testCase.info != null
         && testCase.info.optionsFromFile['isMultitest']) {
       return _didMultitestFail(errors, staticWarnings);
     }
     return _didStandardTestFail(errors, staticWarnings);
   }
@@ skipping 754 matching lines @@
         // the developer doesn't waste his or her time trying to fix a bunch of
         // tests that appear to be broken but were actually just flakes that
         // didn't get retried because there had already been one failure.
         bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
         new RunningProcess(test, allowRetry, this).start();
       }
       _numProcesses++;
     }
   }
 }