Issue 9845019: Port count-based profiler to x64

Issue 9845019: Port count-based profiler to x64 (Closed)

Created:
8 years, 9 months ago by Jakob Kummerow

Modified:
8 years, 9 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Port count-based profiler to x64 Committed: https://code.google.com/p/v8/source/detail?r=11159

Patch Set 3 : addressed comments #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+162 lines, -143 lines)			Patch
M	src/arm/full-codegen-arm.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/debug.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/full-codegen.h	View		2 chunks	+1 line, -7 lines	0 comments	Download
M	src/full-codegen.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/ia32/deoptimizer-ia32.cc	View		2 chunks	+8 lines, -8 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/objects.h	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/runtime-profiler.cc	View	1	2 chunks	+0 lines, -8 lines	0 comments	Download
M	src/x64/deoptimizer-x64.cc	View	1 2	3 chunks	+44 lines, -12 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View		28 chunks	+109 lines, -54 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danno

LGTM with comments. http://codereview.chromium.org/9845019/diff/3001/src/x64/deoptimizer-x64.cc File src/x64/deoptimizer-x64.cc (right): http://codereview.chromium.org/9845019/diff/3001/src/x64/deoptimizer-x64.cc#newcode150 src/x64/deoptimizer-x64.cc:150: ASSERT_EQ(kJnsOffsetDebugCode, *(call_target_address - 2)); Whoa, this ...

8 years, 9 months ago (2012-03-26 14:27:06 UTC) #2

Jakob Kummerow

8 years, 9 months ago (2012-03-27 11:17:09 UTC) #3

Thanks for the review. Landing.

https://chromiumcodereview.appspot.com/9845019/diff/3001/src/x64/deoptimizer-...
File src/x64/deoptimizer-x64.cc (right):

https://chromiumcodereview.appspot.com/9845019/diff/3001/src/x64/deoptimizer-...
src/x64/deoptimizer-x64.cc:150: ASSERT_EQ(kJnsOffsetDebugCode,
*(call_target_address - 2));
On 2012/03/26 14:27:06, danno wrote:
> Whoa, this was totally non-obvious, perhaps a comment about the different code
> size.

Done.

https://chromiumcodereview.appspot.com/9845019/diff/3001/src/x64/full-codegen...
File src/x64/full-codegen-x64.cc (right):

https://chromiumcodereview.appspot.com/9845019/diff/3001/src/x64/full-codegen...
src/x64/full-codegen-x64.cc:364: EmitProfilingCounterReset();
On 2012/03/26 14:27:06, danno wrote:
> Perhaps you could save code size be doing this in the InterruptStub? Would
make
> the generated code smaller. Another CL?

Yeah, in another CL.

Expand Messages | Collapse Messages