chrome/browser/extensions/api/declarative_webrequest/webrequest_rule.cc - Issue 9844028: Implement rules removal for WebRequestRulesRegistry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_rule.cc

Issue 9844028: Implement rules removal for WebRequestRulesRegistry (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/url_matcher_unittest.cc ('k') | chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_rule.cc

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rule.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rule.cc

index d08f76963a92a7a26f6eb89b5a6bb644d47ac594..a05cdcaea79695a5c0b519afd9310d16ee125abe 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rule.cc

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rule.cc

@@ -58,7 +58,7 @@ scoped_ptr<WebRequestRule> WebRequestRule::Create(

return error_result.Pass();

}

- GlobalRuleId rule_id = make_pair(extension_id, *(rule->id));

+ GlobalRuleId rule_id(extension_id, *(rule->id));

return scoped_ptr<WebRequestRule>(

new WebRequestRule(rule_id, conditions.Pass(), actions.Pass()));

}