Issue 9844025: Fix hidden properties to ignore [[Extensible]].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9844025: Fix hidden properties to ignore [[Extensible]]. (Closed)

Created:
8 years, 9 months ago by Michael Starzinger

Modified:
8 years, 8 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix hidden properties to ignore [[Extensible]]. The [[Extensible]] property prevented the very first hidden property from being added. If any hidden property was added to the object before preventing extension, adding subsequent hidden properties would have succeed however. R=svenpanne@chromium.org BUG=v8:2034 TEST=mjsunit/regress/regress-2034 Committed: https://code.google.com/p/v8/source/detail?r=11202

Patch Set 1 #

Patch Set 2 : Add comment. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -7 lines)			Patch
	M	src/objects.cc	View	1	1 chunk	+5 lines, -7 lines	0 comments	Download
	A	test/mjsunit/regress/regress-2034.js	View		1 chunk	+46 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

8 years, 8 months ago (2012-03-29 09:07:53 UTC) #2

LGTM. This CL is just another strong hint that we should clean up the property
access mess eventually, currently checks and modifications are totally mixed
beyond comprehensibility...

Expand Messages | Collapse Messages