Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(103)

Issue 9844025: Fix hidden properties to ignore [[Extensible]]. (Closed)

Created:
7 years, 4 months ago by Michael Starzinger
Modified:
7 years, 4 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Fix hidden properties to ignore [[Extensible]]. The [[Extensible]] property prevented the very first hidden property from being added. If any hidden property was added to the object before preventing extension, adding subsequent hidden properties would have succeed however. R=svenpanne@chromium.org BUG=v8:2034 TEST=mjsunit/regress/regress-2034 Committed: https://code.google.com/p/v8/source/detail?r=11202

Patch Set 1 #

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -7 lines) Patch
M src/objects.cc View 1 1 chunk +5 lines, -7 lines 0 comments Download
A test/mjsunit/regress/regress-2034.js View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
7 years, 4 months ago (2012-03-28 16:59:26 UTC) #1
Sven Panne
7 years, 4 months ago (2012-03-29 09:07:53 UTC) #2
LGTM. This CL is just another strong hint that we should clean up the property
access mess eventually, currently checks and modifications are totally mixed
beyond comprehensibility...

Powered by Google App Engine
This is Rietveld 408576698