Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 9844021: Skia DEPS roll to 3513 (Closed)

Created:
8 years, 9 months ago by epoger
Modified:
8 years, 9 months ago
Reviewers:
bsalomon, reed1
CC:
chromium-reviews, skia-dev_google.com
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
control group is https://chromiumcodereview.appspot.com/9791063 I will request review once the trybots come back.
8 years, 9 months ago (2012-03-28 14:13:24 UTC) #1
epoger
Note that these are the only two actual code changes in the deps roll: http://code.google.com/p/skia/source/detail?r=3507 ...
8 years, 9 months ago (2012-03-28 17:50:39 UTC) #2
epoger
The trybot results look mostly good to me, but I am concerned about linux_gpu. I ...
8 years, 9 months ago (2012-03-28 17:51:13 UTC) #3
bsalomon
Those linux_gpu tests fail periodically as a group. Here is an example control run that ...
8 years, 9 months ago (2012-03-28 17:52:56 UTC) #4
bsalomon
8 years, 9 months ago (2012-03-28 17:53:01 UTC) #5
Oh and LGTM.

On Wed, Mar 28, 2012 at 1:52 PM, Brian Salomon <bsalomon@google.com> wrote:

> Those linux_gpu tests fail periodically as a group. Here is an example
> control run that shows the same failures:
> http://codereview.chromium.org/9252024/
>
>
> On Wed, Mar 28, 2012 at 1:51 PM, <epoger@google.com> wrote:
>
>> The trybot results look mostly good to me, but I am concerned about
>> linux_gpu.
>> I have launched another instance of the this trybot to see if it
>> encounters the
>> same errors:
>> http://build.chromium.org/p/**tryserver.chromium/**
>>
buildstatus?builder=linux_gpu&**number=121<http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_gpu&number=121>
>>
>> In the meanwhile, if anyone is confident that the linux_gpu failures are
>> not
>> related to the DEPS roll, LG this change and I will land it…
>>
>> linux : 2 new browser_test failures, but they look like flakes
>> linux_gpu : 4 new gpu_test failures
>>  GpuPixelBrowserTest.**WebGLGreenTriangle
>>  GpuPixelBrowserTest.**CSS3DBlueBox
>>  Canvas2DPixelTestHD.**Canvas2DRedBoxHD
>>  Canvas2DPixelTestSD.**Canvas2DRedBoxSD
>> linux_chromeos : 1 new browser_test failure, but it looks like a flake
>> linux_layout : no new failures
>> linux_layout_rel : green
>> linux_shared : green
>>
>> mac : green
>> mac_gpu : green
>> mac_layout : 1 new webkit_test failure, looks like a flake
>>  fast/writing-mode/broken-**ideograph-small-caps.html = CRASH
>> mac_layout_rel : green
>>
>> win : green
>> win_gpu : green except for meaningless update_scripts failure
>> win_layout : link failed due to size, just like control group
>> win_layout_rel : green
>>
>> android : green
>>
>>
>>
https://chromiumcodereview.**appspot.com/9844021/<https://chromiumcodereview....
>>
>
>

Powered by Google App Engine
This is Rietveld 408576698