Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9844020: Move the Sudden Motion Sensor library into third_party. (Closed)

Created:
8 years, 9 months ago by hans
Modified:
8 years, 8 months ago
Reviewers:
open-source-third-party-reviews, Avi (use Gerrit), Steve Block, Leandro Graciá Gil, Daniel Berlin
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move the Sudden Motion Sensor library into third_party. BUG=118913 TEST=manual (see instructions at http://code.google.com/p/chromium/issues/detail?id=44654#c11) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129588

Patch Set 1 #

Total comments: 3

Patch Set 2 : applying steve's suggestion #

Total comments: 2

Patch Set 3 : fix leandro and avi's comments #

Patch Set 4 : update DEPS (yes, this file has dos line endings) #

Patch Set 5 : DEPS: convert line endings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -544 lines) Patch
M content/browser/device_orientation/DEPS View 1 2 3 4 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/device_orientation/accelerometer_mac.h View 3 chunks +5 lines, -73 lines 0 comments Download
M content/browser/device_orientation/accelerometer_mac.cc View 1 3 chunks +10 lines, -367 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/sudden_motion_sensor/LICENSE View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/sudden_motion_sensor/README.chromium View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/sudden_motion_sensor/sudden_motion_sensor.gyp View 1 chunk +19 lines, -0 lines 0 comments Download
A + third_party/sudden_motion_sensor/sudden_motion_sensor_mac.h View 3 chunks +9 lines, -19 lines 0 comments Download
A + third_party/sudden_motion_sensor/sudden_motion_sensor_mac.cc View 1 2 10 chunks +21 lines, -79 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
hans
8 years, 9 months ago (2012-03-28 13:34:43 UTC) #1
Steve Block
lgtm Thanks! http://codereview.chromium.org/9844020/diff/1/content/browser/device_orientation/accelerometer_mac.cc File content/browser/device_orientation/accelerometer_mac.cc (right): http://codereview.chromium.org/9844020/diff/1/content/browser/device_orientation/accelerometer_mac.cc#newcode101 content/browser/device_orientation/accelerometer_mac.cc:101: return true; return sudden_motion_sensor_.get() ?
8 years, 9 months ago (2012-03-28 13:56:16 UTC) #2
Daniel Berlin
lgtm
8 years, 9 months ago (2012-03-28 14:16:58 UTC) #3
hans
On 2012/03/28 13:56:16, Steve Block wrote: > lgtm > > Thanks! > > http://codereview.chromium.org/9844020/diff/1/content/browser/device_orientation/accelerometer_mac.cc > ...
8 years, 9 months ago (2012-03-28 14:17:00 UTC) #4
hans
avi: OWNERS approval for content/ ?
8 years, 9 months ago (2012-03-28 14:17:24 UTC) #5
Leandro Graciá Gil
LGTM. https://chromiumcodereview.appspot.com/9844020/diff/1/third_party/sudden_motion_sensor/sudden_motion_sensor_mac.cc File third_party/sudden_motion_sensor/sudden_motion_sensor_mac.cc (right): https://chromiumcodereview.appspot.com/9844020/diff/1/third_party/sudden_motion_sensor/sudden_motion_sensor_mac.cc#newcode101 third_party/sudden_motion_sensor/sudden_motion_sensor_mac.cc:101: const SuddenMotionSensor::GenericMacbookSensor SuddenMotionSensor::kGenericSensor = { More than 80 ...
8 years, 9 months ago (2012-03-28 14:22:44 UTC) #6
Avi (use Gerrit)
lgtm https://chromiumcodereview.appspot.com/9844020/diff/12/third_party/sudden_motion_sensor/README.chromium File third_party/sudden_motion_sensor/README.chromium (right): https://chromiumcodereview.appspot.com/9844020/diff/12/third_party/sudden_motion_sensor/README.chromium#newcode17 third_party/sudden_motion_sensor/README.chromium:17: (see the original code review at http://codereview.chromium.org/3169040/show) and ...
8 years, 9 months ago (2012-03-28 14:30:20 UTC) #7
hans
https://chromiumcodereview.appspot.com/9844020/diff/1/third_party/sudden_motion_sensor/sudden_motion_sensor_mac.cc File third_party/sudden_motion_sensor/sudden_motion_sensor_mac.cc (right): https://chromiumcodereview.appspot.com/9844020/diff/1/third_party/sudden_motion_sensor/sudden_motion_sensor_mac.cc#newcode101 third_party/sudden_motion_sensor/sudden_motion_sensor_mac.cc:101: const SuddenMotionSensor::GenericMacbookSensor SuddenMotionSensor::kGenericSensor = { On 2012/03/28 14:22:44, Leandro ...
8 years, 9 months ago (2012-03-28 14:57:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/9844020/4003
8 years, 9 months ago (2012-03-28 14:59:11 UTC) #9
commit-bot: I haz the power
Can't apply patch for file content/browser/device_orientation/DEPS. While running patch -p1 --forward --force; patching file content/browser/device_orientation/DEPS ...
8 years, 9 months ago (2012-03-28 14:59:17 UTC) #10
Avi (use Gerrit)
LGTM
8 years, 9 months ago (2012-03-28 15:00:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/9844020/1017
8 years, 9 months ago (2012-03-28 15:03:38 UTC) #12
commit-bot: I haz the power
8 years, 9 months ago (2012-03-28 15:03:42 UTC) #13 
Can't apply patch for file content/browser/device_orientation/DEPS.
While running patch -p1 --forward --force;
patching file content/browser/device_orientation/DEPS
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file
content/browser/device_orientation/DEPS.rej

Powered by Google App Engine
This is Rietveld 408576698