Issue 9844018: Keep a histogram of Flash version numbers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9844018: Keep a histogram of Flash version numbers. (Closed)

Created:
8 years, 8 months ago by Chris Evans

Modified:
8 years, 8 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Keep a histogram of Flash version numbers. BUG=120634 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129458

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	M	webkit/plugins/npapi/webplugin_impl.cc	View	1	5 chunks	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bernhard Bauer

https://chromiumcodereview.appspot.com/9844018/diff/1/webkit/plugins/npapi/webplugin_impl.cc File webkit/plugins/npapi/webplugin_impl.cc (right): https://chromiumcodereview.appspot.com/9844018/diff/1/webkit/plugins/npapi/webplugin_impl.cc#newcode1019 webkit/plugins/npapi/webplugin_impl.cc:1019: ClientInfo* client_info = GetClientInfoFromLoader(loader); Can you put this (and ...

8 years, 8 months ago (2012-03-28 13:19:29 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/9844018/2002

8 years, 8 months ago (2012-03-28 13:54:13 UTC) #4