Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: webkit/plugins/npapi/plugin_group.cc

Issue 9844016: Revert 129322 - revert 128949 (and dependent 129252) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/npapi/plugin_group.h ('k') | webkit/plugins/npapi/plugin_group_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/npapi/plugin_group.cc
===================================================================
--- webkit/plugins/npapi/plugin_group.cc (revision 129385)
+++ webkit/plugins/npapi/plugin_group.cc (working copy)
@@ -20,8 +20,6 @@
// static
const char PluginGroup::kAdobeReaderGroupName[] = "Adobe Acrobat";
-const char PluginGroup::kAdobeReaderUpdateURL[] =
- "http://get.adobe.com/reader/";
const char PluginGroup::kJavaGroupName[] = "Java";
const char PluginGroup::kQuickTimeGroupName[] = "QuickTime";
const char PluginGroup::kShockwaveGroupName[] = "Shockwave";
@@ -32,8 +30,7 @@
VersionRange::VersionRange(const VersionRangeDefinition& definition)
: low_str(definition.version_matcher_low),
high_str(definition.version_matcher_high),
- min_str(definition.min_version),
- requires_authorization(definition.requires_authorization) {
+ min_str(definition.min_version) {
if (!low_str.empty())
low.reset(Version::GetVersionFromString(low_str));
if (!high_str.empty())
@@ -60,24 +57,20 @@
low.reset(Version::GetVersionFromString(other.low_str));
high.reset(Version::GetVersionFromString(other.high_str));
min.reset(Version::GetVersionFromString(other.min_str));
- requires_authorization = other.requires_authorization;
}
PluginGroup::PluginGroup(const string16& group_name,
const string16& name_matcher,
- const std::string& update_url,
const std::string& identifier)
: identifier_(identifier),
group_name_(group_name),
- name_matcher_(name_matcher),
- update_url_(update_url) {
+ name_matcher_(name_matcher) {
}
void PluginGroup::InitFrom(const PluginGroup& other) {
identifier_ = other.identifier_;
group_name_ = other.group_name_;
name_matcher_ = other.name_matcher_;
- update_url_ = other.update_url_;
version_ranges_ = other.version_ranges_;
web_plugin_infos_ = other.web_plugin_infos_;
}
@@ -96,7 +89,6 @@
const PluginGroupDefinition& definition) {
PluginGroup* group = new PluginGroup(ASCIIToUTF16(definition.name),
ASCIIToUTF16(definition.name_matcher),
- definition.update_url,
definition.identifier);
for (size_t i = 0; i < definition.num_versions; ++i)
group->version_ranges_.push_back(VersionRange(definition.versions[i]));
@@ -126,7 +118,7 @@
/*static*/
PluginGroup* PluginGroup::FromWebPluginInfo(const WebPluginInfo& wpi) {
// Create a matcher from the name of this plugin.
- return new PluginGroup(wpi.name, wpi.name, std::string(),
+ return new PluginGroup(wpi.name, wpi.name,
GetIdentifier(wpi));
}
@@ -256,19 +248,6 @@
return false;
}
-bool PluginGroup::RequiresAuthorization(const WebPluginInfo& plugin) const {
- scoped_ptr<Version> version(CreateVersionFromString(plugin.version));
- if (!version.get())
- return false;
-
- for (size_t i = 0; i < version_ranges_.size(); ++i) {
- if (IsVersionInRange(*version, version_ranges_[i]) &&
- version_ranges_[i].requires_authorization)
- return true;
- }
- return false;
-}
-
bool PluginGroup::IsEmpty() const {
return web_plugin_infos_.empty();
}
Property changes on: webkit/plugins/npapi/plugin_group.cc
___________________________________________________________________
Deleted: svn:mergeinfo
Reverse-merged /branches/chrome_webkit_merge_branch/src/webkit/plugins/npapi/plugin_group.cc:r3734-4217,4606-5108,5177-5263
« no previous file with comments | « webkit/plugins/npapi/plugin_group.h ('k') | webkit/plugins/npapi/plugin_group_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698