Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: content/utility/utility_thread_impl.cc

Issue 9844016: Revert 129322 - revert 128949 (and dependent 129252) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/plugins_ui.cc ('k') | webkit/plugins/npapi/plugin_group.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/utility/utility_thread_impl.cc
===================================================================
--- content/utility/utility_thread_impl.cc (revision 129385)
+++ content/utility/utility_thread_impl.cc (working copy)
@@ -147,19 +147,16 @@
gfx::GtkInitFromCommandLine(*CommandLine::ForCurrentProcess());
#endif
+ ScopedVector<webkit::npapi::PluginGroup> plugin_groups;
+ // TODO(bauerb): If we restart loading plug-ins, we might mess up the logic in
+ // PluginList::ShouldLoadPlugin due to missing the previously loaded plug-ins
+ // in |plugin_groups|.
for (size_t i = 0; i < plugin_paths.size(); ++i) {
- ScopedVector<webkit::npapi::PluginGroup> plugin_groups;
- plugin_list->LoadPlugin(plugin_paths[i], &plugin_groups);
-
- if (plugin_groups.empty()) {
+ webkit::WebPluginInfo plugin;
+ if (!plugin_list->LoadPlugin(plugin_paths[i], &plugin_groups, &plugin))
Send(new UtilityHostMsg_LoadPluginFailed(i, plugin_paths[i]));
- continue;
- }
-
- const webkit::npapi::PluginGroup* group = plugin_groups[0];
- DCHECK_EQ(group->web_plugin_infos().size(), 1u);
-
- Send(new UtilityHostMsg_LoadedPlugin(i, group->web_plugin_infos().front()));
+ else
+ Send(new UtilityHostMsg_LoadedPlugin(i, plugin));
}
ReleaseProcessIfNeeded();
« no previous file with comments | « chrome/browser/ui/webui/plugins_ui.cc ('k') | webkit/plugins/npapi/plugin_group.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698