Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 9844003: More type checking performance improvements and a bug fix in intrinsifier. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/code_generator_ia32.cc ('K') | « runtime/vm/code_generator_ia32.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_ia32.cc
===================================================================
--- runtime/vm/intrinsifier_ia32.cc (revision 5913)
+++ runtime/vm/intrinsifier_ia32.cc (working copy)
@@ -246,11 +246,11 @@
__ movl(EBX, Address(ESP, + 3 * kWordSize)); // Array.
__ movl(EBX, FieldAddress(EBX, type_args_field_offset));
// EBX: Type arguments of array.
- __ movl(EAX, FieldAddress(EBX, Object::class_offset()));
+ __ cmpl(EBX, raw_null);
+ __ j(EQUAL, &checked_ok, Assembler::kNearJump);
// Check if it's Dynamic.
- __ cmpl(EAX, raw_null);
- __ j(EQUAL, &checked_ok, Assembler::kNearJump);
// For now handle only TypeArguments and bail out if InstantiatedTypeArgs.
+ __ movl(EAX, FieldAddress(EBX, Object::class_offset()));
__ CompareObject(EAX, Object::ZoneHandle(Object::type_arguments_class()));
__ j(NOT_EQUAL, &fall_through, Assembler::kNearJump);
// Get type at index 0.
« runtime/vm/code_generator_ia32.cc ('K') | « runtime/vm/code_generator_ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698