Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9839067: Cleanup: Removing obsolete chromePrivate.decodeJPEG API. (Closed)

Created:
8 years, 9 months ago by glotov
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Removing obsolete chromePrivate.decodeJPEG API. BUG=113657 TEST=unit Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129394

Patch Set 1 #

Patch Set 2 : unittest fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -224 lines) Patch
D chrome/browser/extensions/extension_chrome_private_apitest.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/chrome_renderer.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/common_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/api/chromePrivate.json View 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/js/api_page_generator.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_permission_set.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_permission_set.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_permission_set_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
D chrome/renderer/extensions/chrome_private_custom_bindings.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/renderer/extensions/chrome_private_custom_bindings.cc View 1 chunk +0 lines, -85 lines 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.cc View 4 chunks +0 lines, -7 lines 0 comments Download
M chrome/renderer/renderer_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/renderer/resources/extensions/chrome_private_custom_bindings.js View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/test/data/extensions/api_test/decode_jpeg/background.js View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/test/data/extensions/api_test/decode_jpeg/manifest.json View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/test/data/extensions/api_test/decode_jpeg/testdata.js View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
glotov
Hi! This is a cleanup change. Please take a look.
8 years, 9 months ago (2012-03-23 19:42:21 UTC) #1
Nikita (slow)
lgtm
8 years, 9 months ago (2012-03-23 21:30:38 UTC) #2
glotov
Antony, I need your owner approval. On 2012/03/23 21:30:38, Nikita Kostylev wrote: > lgtm
8 years, 9 months ago (2012-03-27 15:28:53 UTC) #3
asargent_no_longer_on_chrome
8 years, 9 months ago (2012-03-27 18:09:53 UTC) #4 
LGTM! Nice to see this get taken out.

Powered by Google App Engine
This is Rietveld 408576698