views: Refactor the way we get the combo box font.

views: Refactor the way we get the combo box font.

R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128915

[sky, 2012-03-23 15:36:38]

http://codereview.chromium.org/9839034/diff/1/ui/views/controls/combobox/nati...
File ui/views/controls/combobox/native_combobox_views.cc (right):

http://codereview.chromium.org/9839034/diff/1/ui/views/controls/combobox/nati...
ui/views/controls/combobox/native_combobox_views.cc:51: const gfx::Font&
GetFont() {
Maybe we should promote this to combobox so that both places care share the
code.

[tfarina, 2012-03-23 16:45:47]

On 2012/03/23 15:36:38, sky wrote:
>
http://codereview.chromium.org/9839034/diff/1/ui/views/controls/combobox/nati...
> File ui/views/controls/combobox/native_combobox_views.cc (right):
> 
>
http://codereview.chromium.org/9839034/diff/1/ui/views/controls/combobox/nati...
> ui/views/controls/combobox/native_combobox_views.cc:51: const gfx::Font&
> GetFont() {
> Maybe we should promote this to combobox so that both places care share the
> code.

Done. PTAL.

[sky, 2012-03-23 18:13:34]

http://codereview.chromium.org/9839034/diff/6003/ui/views/controls/combobox/c...
File ui/views/controls/combobox/combobox.h (right):

http://codereview.chromium.org/9839034/diff/6003/ui/views/controls/combobox/c...
ui/views/controls/combobox/combobox.h:33: static const gfx::Font& GetFont();
static methods shouldn't be before the constructor/destructor.

[tfarina, 2012-03-23 18:21:31]

http://codereview.chromium.org/9839034/diff/6003/ui/views/controls/combobox/c...
File ui/views/controls/combobox/combobox.h (right):

http://codereview.chromium.org/9839034/diff/6003/ui/views/controls/combobox/c...
ui/views/controls/combobox/combobox.h:33: static const gfx::Font& GetFont();
On 2012/03/23 18:13:34, sky wrote:
> static methods shouldn't be before the constructor/destructor.
Fixed.

[tfarina, 2012-03-23 23:07:55]

On 2012/03/23 18:21:31, tfarina wrote:
>
http://codereview.chromium.org/9839034/diff/6003/ui/views/controls/combobox/c...
> File ui/views/controls/combobox/combobox.h (right):
> 
>
http://codereview.chromium.org/9839034/diff/6003/ui/views/controls/combobox/c...
> ui/views/controls/combobox/combobox.h:33: static const gfx::Font& GetFont();
> On 2012/03/23 18:13:34, sky wrote:
> > static methods shouldn't be before the constructor/destructor.
> Fixed.

[sky, 2012-03-26 14:42:49]

LGTM