Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 9839023: Revert 102385 - Use Skia's implementation of Gaussian blur when accelerated filters (Closed)

Created:
8 years, 9 months ago by karen
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1025/
Visibility:
Public.

Description

Revert 102385 - Use Skia's implementation of Gaussian blur when accelerated filters are enabled. https://bugs.webkit.org/show_bug.cgi?id=73949 Reviewed by Zoltan Herczeg. In the future, this will be covered by the SVG tests run in GPU mode. * WebCore.gypi: Add FEGaussianBlurSkia.cpp to the build. * platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::platformApplySoftware): Call out to platformApplySkia() when USE_SKIA is enabled. * platform/graphics/filters/FEGaussianBlur.h: platformApplySkia() declaration. * platform/graphics/filters/skia: Added. * platform/graphics/filters/skia/FEGaussianBlurSkia.cpp: Added. (WebCore::FEGaussianBlur::platformApplySkia): On the Skia port, use SkBlurImageFilter for drawing Gaussian blurs in accelerated mode. * platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::copyImage): Implement ImageBuffer::copyImage() with DontCopyBackingStore semantics. TBR=senorblanco@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=111763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M Source/WebCore/WebCore.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/platform/graphics/filters/FEGaussianBlur.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
karen
8 years, 9 months ago (2012-03-22 21:14:20 UTC) #1
senorblanco
8 years, 9 months ago (2012-03-22 21:15:18 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698