Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 9839009: [filebrowser] Show progress indication, while files from GData are being downloaded. (Closed)

Created:
8 years, 9 months ago by dgozman
Modified:
8 years, 9 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[filebrowser] Show progress indication, while files from GData are being downloaded. BUG=chromium-os:27504 TEST=See bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128920

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -58 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/css/file_manager.css View 1 2 3 4 5 3 chunks +33 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 2 3 4 5 5 chunks +132 lines, -58 lines 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/main.html View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
dgozman
May you have a look, please?
8 years, 9 months ago (2012-03-22 16:15:28 UTC) #1
zel
https://chromiumcodereview.appspot.com/9839009/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right): https://chromiumcodereview.appspot.com/9839009/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc#newcode1842 chrome/browser/chromeos/extensions/file_browser_private_api.cc:1842: FilePath("/special/gdata").Append(file_path), THis does not look right. Why do you ...
8 years, 9 months ago (2012-03-22 17:21:46 UTC) #2
zel
8 years, 9 months ago (2012-03-22 17:21:47 UTC) #3
Vladislav Kaznacheev
https://chromiumcodereview.appspot.com/9839009/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/9839009/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode4010 chrome/browser/resources/file_manager/js/file_manager.js:4010: this.callSelectFilesApiAndClose_(selection); We used to make this call from setTimeout. ...
8 years, 9 months ago (2012-03-23 07:20:52 UTC) #4
dgozman
PTAL https://chromiumcodereview.appspot.com/9839009/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc File chrome/browser/chromeos/extensions/file_browser_private_api.cc (right): https://chromiumcodereview.appspot.com/9839009/diff/1/chrome/browser/chromeos/extensions/file_browser_private_api.cc#newcode1842 chrome/browser/chromeos/extensions/file_browser_private_api.cc:1842: FilePath("/special/gdata").Append(file_path), On 2012/03/22 17:21:46, zel wrote: > THis ...
8 years, 9 months ago (2012-03-23 12:44:05 UTC) #5
Vladislav Kaznacheev
LGTM with a nit. https://chromiumcodereview.appspot.com/9839009/diff/7001/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/9839009/diff/7001/chrome/browser/resources/file_manager/js/file_manager.js#newcode4062 chrome/browser/resources/file_manager/js/file_manager.js:4062: // Accroding to API cancel ...
8 years, 9 months ago (2012-03-23 13:11:13 UTC) #6
Vladislav Kaznacheev
http://codereview.chromium.org/9839009/diff/8001/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): http://codereview.chromium.org/9839009/diff/8001/chrome/browser/resources/file_manager/js/file_manager.js#newcode4043 chrome/browser/resources/file_manager/js/file_manager.js:4043: done += status.processed - old; if old == 1 ...
8 years, 9 months ago (2012-03-23 14:32:10 UTC) #7
dgozman
http://codereview.chromium.org/9839009/diff/8001/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): http://codereview.chromium.org/9839009/diff/8001/chrome/browser/resources/file_manager/js/file_manager.js#newcode4043 chrome/browser/resources/file_manager/js/file_manager.js:4043: done += status.processed - old; On 2012/03/23 14:32:10, Vladislav ...
8 years, 9 months ago (2012-03-23 14:37:31 UTC) #8
Vladislav Kaznacheev
lgtm
8 years, 9 months ago (2012-03-23 14:40:24 UTC) #9
zel
lgtm
8 years, 9 months ago (2012-03-23 15:38:27 UTC) #10
zel
On 2012/03/23 15:38:27, zel wrote: > lgtm What's the status here? Why this hasn't landed ...
8 years, 9 months ago (2012-03-25 00:27:08 UTC) #11
zel
http://codereview.chromium.org/9839009/diff/6003/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/9839009/diff/6003/chrome/app/generated_resources.grd#newcode10245 chrome/app/generated_resources.grd:10245: + Preparing you will most likely need to revert ...
8 years, 9 months ago (2012-03-25 01:03:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/9839009/15001
8 years, 9 months ago (2012-03-26 14:25:52 UTC) #13
commit-bot: I haz the power
8 years, 9 months ago (2012-03-26 16:29:37 UTC) #14
Change committed as 128920

Powered by Google App Engine
This is Rietveld 408576698