chrome/browser/ui/views/tabs/tab_strip.h - Issue 983853002: Hide close buttons of inactive stacked tabs by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/tabs/tab_strip.h

Issue 983853002: Hide close buttons of inactive stacked tabs by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: force tab layout Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/tabs/tab_controller.h ('k') | chrome/browser/ui/views/tabs/tab_strip.cc » ('j') | chrome/browser/ui/views/tabs/tab_strip_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/tabs/tab_strip.h

diff --git a/chrome/browser/ui/views/tabs/tab_strip.h b/chrome/browser/ui/views/tabs/tab_strip.h

index 8bef5ae4a94149e6d6ba481964afe5db17c53f8f..2c95ca5c703a81cfbdc7f54583d53be0f4d09366 100644

--- a/chrome/browser/ui/views/tabs/tab_strip.h

+++ b/chrome/browser/ui/views/tabs/tab_strip.h

@@ -213,7 +213,7 @@ class TabStrip : public views::View,

// TabController overrides:

const ui::ListSelectionModel& GetSelectionModel() override;

bool SupportsMultipleSelection() override;

- bool ShouldHideCloseButtonForInactiveTab(const Tab* tab) override;

+ bool ShouldHideCloseButtonForInactiveTabs() override;

void SelectTab(Tab* tab) override;

void ExtendSelectionTo(Tab* tab) override;

void ToggleSelected(Tab* tab) override;

@@ -271,10 +271,11 @@ class TabStrip : public views::View,

friend class TabDragController;

friend class TabDragControllerTest;

+ friend class TabStripTest;

FRIEND_TEST_ALL_PREFIXES(TabDragControllerTest, GestureEndShouldEndDragTest);

friend class TabStripTest;

FRIEND_TEST_ALL_PREFIXES(TabStripTest, TabHitTestMaskWhenStacked);

- FRIEND_TEST_ALL_PREFIXES(TabStripTest, ClippedTabCloseButton);

+ FRIEND_TEST_ALL_PREFIXES(TabStripTest, TabCloseButtonVisibilityWhenStacked);

// Used during a drop session of a url. Tracks the position of the drop as

// well as a window used to highlight where the drop occurs.