Hide close buttons of inactive stacked tabs by default

chrome/browser/ui/views/tabs/tab_strip.cc

Index: chrome/browser/ui/views/tabs/tab_strip.cc
diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc b/chrome/browser/ui/views/tabs/tab_strip.cc
index cffe4a382cf33dd5dae4ce08be2b7f75e74bd46d..3453889a2397f07881670cdb56bc9b453959eb07 100644
--- a/chrome/browser/ui/views/tabs/tab_strip.cc
+++ b/chrome/browser/ui/views/tabs/tab_strip.cc
@@ -969,28 +969,12 @@ bool TabStrip::SupportsMultipleSelection() {
   return touch_layout_ == NULL;
 }
 
-// TODO(tdanderson): Modify this logic and clean up related code once a
-//                   decision has been made on the experimental
-//                   flag --tab-close-buttons-hidden-with-touch.
-bool TabStrip::ShouldHideCloseButtonForInactiveTab(const Tab* tab) {
-  DCHECK(!tab->IsActive());
-
-  // Do not force the close button to hide if mouse was used as
-  // the last input type to interact with the tab strip.
-  if (!stacked_layout_)
+bool TabStrip::ShouldHideCloseButtonForInactiveTabs() {
+  if (!touch_layout_)

[sky, 2015/03/09 19:55:59]

I was wrong here. My understanding is you always want to hide the close buttons
if the user use a touch device on the tabstrip. You should key off
stacked_layout_ for that. touch_layout_ means we're actively in the stacked
mode, which is slightly different. (The names I have here are confusing, I need
to change them).

[tdanderson, 2015/03/11 18:01:38]

Actually, you were right. Using |touch_layout_| is what we want to be doing. The
desired behavior is to only hide the tab close buttons of inactive tabs when
we're actively in stacked mode. My CL description was a bit misleading, so I
changed it.

     return false;
 
-  std::string switch_value =
-      base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
-          switches::kTabCloseButtonsHiddenWithTouch);
-  int width = tab->width();
-  if (switch_value == "always" ||
-      (switch_value == "narrow" && width < Tab::GetStandardSize().width()) ||
-      (switch_value == "stacked" && width <= Tab::GetTouchWidth())) {
-    return true;
-  }
-
-  return false;
+  return !base::CommandLine::ForCurrentProcess()->HasSwitch(
+      switches::kDisableHideInactiveStackedTabCloseButtons);
 }
 
 void TabStrip::SelectTab(Tab* tab) {