Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 9838101: Added missing strings for gdata business. (Closed)

Created:
8 years, 9 months ago by zel
Modified:
8 years, 9 months ago
Reviewers:
dgozman, joshwoodward1
CC:
chromium-reviews
Visibility:
Public.

Description

Added missing strings for gdata business. Also added strings from http://codereview.chromium.org/9839009/. BUG=chromium-os:28298 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128800

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : updates with content from http://codereview.chromium.org/9839009/ #

Patch Set 4 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 3 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
zel
8 years, 9 months ago (2012-03-25 00:39:43 UTC) #1
joshwoodward1
LGTM
8 years, 9 months ago (2012-03-25 00:40:20 UTC) #2
zel
8 years, 9 months ago (2012-03-25 01:01:10 UTC) #3
zel
more strings added
8 years, 9 months ago (2012-03-25 01:13:08 UTC) #4
joshwoodward
LGTM
8 years, 9 months ago (2012-03-25 01:14:08 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-25 01:15:17 UTC) #6
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698