Issue 9838097: Fix a memory leak; properly initialize inner_parsed before use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9838097: Fix a memory leak; properly initialize inner_parsed before use. (Closed)

Created:
8 years, 9 months ago by ericu

Modified:
8 years, 9 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
http://google-url.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix a memory leak; properly initialize inner_parsed before use.

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
M	src/gurl.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/gurl.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/url_parse.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ericu

Brett: Sorry to bug you, but apparently I left a huge hole in GURL [inactive ...

8 years, 9 months ago (2012-03-24 17:55:27 UTC) #1

ericu

Cool, thanks. Could I get you to commit it on Monday? I'll do the deps ...

8 years, 9 months ago (2012-03-26 02:44:59 UTC) #3

ericu

8 years, 9 months ago (2012-03-26 19:48:32 UTC) #5

Thanks!

On Mon, Mar 26, 2012 at 12:44 PM,  <brettw@chromium.org> wrote:
> Committed as googleurl@169
>
> https://chromiumcodereview.appspot.com/9838097/

Expand Messages | Collapse Messages