Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: content/plugin/plugin_channel.cc

Issue 9838083: Add a sandbox API for broker handle duplication (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/plugin/plugin_channel.cc
===================================================================
--- content/plugin/plugin_channel.cc (revision 128951)
+++ content/plugin/plugin_channel.cc (working copy)
@@ -161,8 +161,7 @@
}
PluginChannel::PluginChannel()
- : renderer_handle_(0),
- renderer_id_(-1),
+ : renderer_id_(-1),
in_send_(0),
incognito_(false),
filter_(new MessageFilter()) {
@@ -173,9 +172,6 @@
}
PluginChannel::~PluginChannel() {
- if (renderer_handle_)
- base::CloseProcessHandle(renderer_handle_);
-
MessageLoop::current()->PostDelayedTask(
FROM_HERE,
base::Bind(&PluginReleaseCallback),
@@ -292,18 +288,7 @@
return filter_->GetModalDialogEvent(containing_window);
}
-void PluginChannel::OnChannelConnected(int32 peer_pid) {
- base::ProcessHandle handle;
- if (!base::OpenProcessHandle(peer_pid, &handle)) {
- NOTREACHED();
- }
- renderer_handle_ = handle;
- NPChannelBase::OnChannelConnected(peer_pid);
-}
-
void PluginChannel::OnChannelError() {
- base::CloseProcessHandle(renderer_handle_);
- renderer_handle_ = 0;
NPChannelBase::OnChannelError();
CleanUp();
}

Powered by Google App Engine
This is Rietveld 408576698