Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: tools/valgrind/drmemory/suppressions.txt

Issue 9838075: suppress GDI usage errors in 3rd-party components (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: further expand 119552 c Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/drmemory/suppressions.txt
diff --git a/tools/valgrind/drmemory/suppressions.txt b/tools/valgrind/drmemory/suppressions.txt
index c271a9043f257b85a144ab6261708e653e3a7764..5b19ebbf7b0c64daa5f503dcf614ac62613e92be 100644
--- a/tools/valgrind/drmemory/suppressions.txt
+++ b/tools/valgrind/drmemory/suppressions.txt
@@ -288,10 +288,47 @@ npapi_test_plugin.dll!NPAPIClient::ExecuteGetJavascriptUrlTest::TimerProc
WARNING
name=http://crbug.com/109963 a
system call NtGdiDeleteObjectApp
+# usually one or two GDI32.dll frames here but sometimes in light mode
+# there are zero. still pretty narrow b/c of frames on either side.
+...
*!skia::BitmapPlatformDevice::BitmapPlatformDeviceData::~BitmapPlatformDeviceData
WARNING
name=http://crbug.com/109963 b
system call NtGdiDeleteObjectApp
-GDI32.dll!*
+# usually one or two GDI32.dll frames here but sometimes in light mode
+# there are zero. still pretty narrow b/c of frames on either side.
+...
*!skia::BitmapPlatformDevice::BitmapPlatformDeviceData::ReleaseBitmapDC
+
+# GDI usage errors in 3rd-party components
+WARNING
+name=http://crbug.com/119552 a
+system call NtGdiDeleteObjectApp
+...
+*!OmniboxViewWin::*
+
+WARNING
+name=http://crbug.com/119552 b
+system call Nt*
+...
+*!ATL::*
+
+WARNING
+name=http://crbug.com/119552 c
+# optional gdi32.dll frame followed by user32.dll
+# TODO(bruening): once have
+# http://code.google.com/p/drmemory/issues/detail?id=846
+# I would do "gdi32.dll!...\nuser32.dll!*"
+*32.dll!*
+...
+shell32.dll!SHGetFileInfoW
+*!IconLoader::ReadIcon
+
+WARNING
+name=http://crbug.com/119552 d
+system call NtGdiDeleteObjectApp
+gdi32.dll!DeleteObject
+riched20.dll!*
+riched20.dll!*
+riched20.dll!*
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698