chrome/browser/ui/webui/ntp/ntp_login_handler.cc - Issue 9838064: Add a sign-in promo message to the Other Devices menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/ntp_login_handler.cc

Issue 9838064: Add a sign-in promo message to the Other Devices menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments, and only enable menu when tab sync is enabled. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/ntp/ntp_login_handler.cc

diff --git a/chrome/browser/ui/webui/ntp/ntp_login_handler.cc b/chrome/browser/ui/webui/ntp/ntp_login_handler.cc

index ca8138defe5af6cb0652afc7aed3ff18ca199290..d5103d035d7c5bb70988ec987a912e76835e1805 100644

--- a/chrome/browser/ui/webui/ntp/ntp_login_handler.cc

+++ b/chrome/browser/ui/webui/ntp/ntp_login_handler.cc

@@ -233,8 +233,9 @@ void NTPLoginHandler::UpdateLogin() {

StringValue header_value(header);

StringValue sub_header_value(sub_header);

StringValue icon_url_value(icon_url);

- web_ui()->CallJavascriptFunction(

- "ntp.updateLogin", header_value, sub_header_value, icon_url_value);

+ base::FundamentalValue is_user_signed_in(!username.empty());

+ web_ui()->CallJavascriptFunction("ntp.updateLogin",

+ header_value, sub_header_value, icon_url_value, is_user_signed_in);

}

// static