Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 9838058: More non-debug logging in Chrome Frame tests. (Closed)

Created:
8 years, 9 months ago by grt (UTC plus 2)
Modified:
8 years, 9 months ago
Reviewers:
robertshield
CC:
chromium-reviews, amit
Visibility:
Public.

Description

More non-debug logging in Chrome Frame tests. There are only good reasons to not use DLOG and DVLOG in test code. Also, avoid a potential race by setting up ChromeFrameTestWithWebServer expectations before launching the browser. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128638

Patch Set 1 #

Patch Set 2 : copyright and formatting tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -65 lines) Patch
M chrome_frame/test/chrome_frame_test_utils.cc View 10 chunks +19 lines, -19 lines 0 comments Download
M chrome_frame/test/chrome_frame_ui_test_utils.cc View 1 4 chunks +9 lines, -9 lines 0 comments Download
M chrome_frame/test/ie_event_sink.cc View 1 10 chunks +17 lines, -17 lines 0 comments Download
M chrome_frame/test/mock_ie_event_sink_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/mock_ie_event_sink_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/test/simulate_input.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome_frame/test/test_server.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/test_with_web_server.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome_frame/test/win_event_receiver.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
grt (UTC plus 2)
8 years, 9 months ago (2012-03-23 15:26:50 UTC) #1
robertshield
On 2012/03/23 15:26:50, grt wrote: LGTM++
8 years, 9 months ago (2012-03-23 16:57:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/9838058/3001
8 years, 9 months ago (2012-03-23 17:10:00 UTC) #3
commit-bot: I haz the power
Try job failure for 9838058-3001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-23 21:23:52 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-23 21:44:50 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698