Expose correct semantics for HTML5 footer element on mac and windows platforms, as per https://bugs…

Expose correct semantics for HTML5 footer element on mac and windows platforms, as per https://bugs.webkit.org/show_bug.cgi?id=78967.

BUG=116114
TEST=Added case to DumpAccessibilityTreeTest.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134212

[dmazzoni, 2012-03-27 00:19:51]

LGTM

Please kick off a try job (git try), as the commit queue does not run all of the
accessibility tests. Then add OWNERS reviewers for rubberstamp.

http://codereview.chromium.org/9838042/diff/1011/webkit/glue/webaccessibility.cc
File webkit/glue/webaccessibility.cc (right):

http://codereview.chromium.org/9838042/diff/1011/webkit/glue/webaccessibility...
webkit/glue/webaccessibility.cc:440: case ROLE_EDITABLE_TEXT: result += "
EDITABLE_TEXT"; break;
Add a debug string for ROLE_FOOTER here, please!

Do you see any reason not to remove the "default" case from this switch? Try
removing it - that should make it a compile error if we forget to add a role
here.

[dmazzoni, 2012-03-27 00:26:45]

Oops, one more thing - did you mean to add footer-expected-mac to this change?

[aboxhall, 2012-03-27 00:28:26]

On 2012/03/27 00:26:45, Dominic Mazzoni wrote:
> Oops, one more thing - did you mean to add footer-expected-mac to this change?

Hm, almost certainly... will fix that and your suggestions and upload; note that
https://chromiumcodereview.appspot.com/9835038/ needs to be submitted before the
mac test will pass.

[David Tseng, 2012-03-27 00:43:16]

lgtm, after adding an expectation for mac.

http://codereview.chromium.org/9838042/diff/1011/content/browser/accessibilit...
File content/browser/accessibility/browser_accessibility_cocoa.mm (right):

http://codereview.chromium.org/9838042/diff/1011/content/browser/accessibilit...
content/browser/accessibility/browser_accessibility_cocoa.mm:558: if
(static_cast<WebAccessibility::Role>( browserAccessibility_->role()) ==
nit; extra space after static_cast(...
if (static_cast<WebAccessibility::Role>( browser....

[commit-bot: I haz the power, 2012-04-12 03:42:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/9838042/11001

[commit-bot: I haz the power, 2012-04-12 03:42:39]

Presubmit check for 9838042-11001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    webkit

[aboxhall, 2012-04-12 03:46:35]

Tony or James, could you take a look at the changes in webkit/glue for me?

[jamesr, 2012-04-12 03:50:27]

lgtm

[commit-bot: I haz the power, 2012-04-12 03:51:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/9838042/11001

[commit-bot: I haz the power, 2012-04-12 06:19:54]

Try job failure for 9838042-11001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-04-26 04:18:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/9838042/11001

[commit-bot: I haz the power, 2012-04-26 06:42:11]

Try job failure for 9838042-11001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-04-26 07:40:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/9838042/33001

[commit-bot: I haz the power, 2012-04-26 08:39:44]

Try job failure for 9838042-33001 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-27 00:37:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/9838042/33001

[commit-bot: I haz the power, 2012-04-27 02:18:31]

Change committed as 134212