dart/frog/leg/elements/elements.dart - Issue 9838038: "Implement" #resource tag and various restrictions on library definitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/frog/leg/elements/elements.dart

Issue 9838038: "Implement" #resource tag and various restrictions on library definitions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/frog/leg/elements/elements.dart

diff --git a/dart/frog/leg/elements/elements.dart b/dart/frog/leg/elements/elements.dart

index 9decaba052c00923c59662494a57461091ebbc9a..87dc94c6c2e68bd65543e46a31b26a69f289fd70 100644

--- a/dart/frog/leg/elements/elements.dart

+++ b/dart/frog/leg/elements/elements.dart

@@ -313,6 +313,8 @@ class LibraryElement extends CompilationUnitElement {

}

});

}

+ bool hasLibraryName() => (!tags.isEmpty()) && tags.reverse().head.isLibrary();

ngeoffray 2012/03/23 17:22:52 The 'reverse' call looks sooooooo expensive for so

ahe 2012/03/24 08:02:03 Especially when the library tag is recorded alread

}

class PrefixElement extends Element {

« no previous file with comments | « dart/frog/leg/compiler.dart ('k') | dart/frog/leg/scanner/scanner_task.dart » ('j') | dart/frog/leg/scanner/scanner_task.dart » ('J')