 Chromium Code Reviews
 Chromium Code Reviews Issue 9838033:
  Upstream native crash handling changes for Android.  (Closed) 
  Base URL: http://git.chromium.org/git/chromium.git@trunk
    
  
    Issue 9838033:
  Upstream native crash handling changes for Android.  (Closed) 
  Base URL: http://git.chromium.org/git/chromium.git@trunk| Index: chrome/app/breakpad_posix.h | 
| diff --git a/chrome/app/breakpad_linux.h b/chrome/app/breakpad_posix.h | 
| similarity index 87% | 
| rename from chrome/app/breakpad_linux.h | 
| rename to chrome/app/breakpad_posix.h | 
| index 4799d721a78c38dd0057ffc8555ff7ffbaa2f91d..994b567b1a00cf73bbe3922987922bcde5975027 100644 | 
| --- a/chrome/app/breakpad_linux.h | 
| +++ b/chrome/app/breakpad_posix.h | 
| @@ -2,8 +2,8 @@ | 
| // Use of this source code is governed by a BSD-style license that can be | 
| // found in the LICENSE file. | 
| -#ifndef CHROME_APP_BREAKPAD_LINUX_H_ | 
| -#define CHROME_APP_BREAKPAD_LINUX_H_ | 
| +#ifndef CHROME_APP_BREAKPAD_POSIX_H_ | 
| 
Mark Mentovai
2012/04/05 14:28:03
No. Move these files back to their old names as we
 
carlosvaldivia
2012/04/05 18:35:56
So what is the cost? Given our compilation filters
 | 
| +#define CHROME_APP_BREAKPAD_POSIX_H_ | 
| #pragma once | 
| #include "base/basictypes.h" | 
| @@ -27,8 +27,9 @@ struct BreakpadInfo { | 
| unsigned distro_length; // Length of |distro|. | 
| bool upload; // Whether to upload or save crash dump. | 
| uint64_t process_start_time; // Uptime of the crashing process. | 
| + uint64_t pid; // PID where applicable. | 
| 
Mark Mentovai
2012/04/05 14:28:03
This addition is of course fine.
 
carlosvaldivia
2012/04/05 18:35:56
Done.
 | 
| }; | 
| extern void HandleCrashDump(const BreakpadInfo& info); | 
| -#endif // CHROME_APP_BREAKPAD_LINUX_H_ | 
| +#endif // CHROME_APP_BREAKPAD_POSIX_H_ |