Issue 9838014: Revert 128152 - Add IDS_ABOUT_CROS_VERSION_LICENSE support back to chrome://chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9838014: Revert 128152 - Add IDS_ABOUT_CROS_VERSION_LICENSE support back to chrome://chrome. (Closed)

Created:
8 years, 9 months ago by Rick Byers

Modified:
8 years, 9 months ago

Reviewers:
Yusuke Sato

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 128152 - Add IDS_ABOUT_CROS_VERSION_LICENSE support back to chrome://chrome. BUG=118348, 119499 TEST=manually checked the following configurations: 1) Google Chrome for Chromebook (with USE=chrome_internal), 2) Chromium for Goobuntu with GYP_DEFINES=chromeos=1, 3) Chromium for Goobuntu without the GYP_DEFINES. Review URL: http://codereview.chromium.org/9705092 TBR=yusukes@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128236

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -22 lines)			Patch
M	chrome/app/chromium_strings.grd	View	1 chunk	+10 lines, -5 lines	0 comments	Download
M	chrome/app/google_chrome_strings.grd	View	1 chunk	+9 lines, -4 lines	0 comments	Download
MM	chrome/browser/resources/help/help.html	View	1 chunk	+0 lines, -3 lines	0 comments	Download
MM	chrome/browser/resources/help/help.js	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/help/help_handler.cc	View	1 chunk	+2 lines, -7 lines	0 comments	Download

Total messages: 1 (0 generated)