Support for ARM NaCl untrusted runtime build.

build/download_nacl_toolchains.py

Index: build/download_nacl_toolchains.py
diff --git a/build/download_nacl_toolchains.py b/build/download_nacl_toolchains.py
index 2fdfa00f37c7fa9f72db6ed79c3c88ca25ae74f2..00bc5e88b13d6caac7ce2cc05a5f1c2bd7431403 100755
--- a/build/download_nacl_toolchains.py
+++ b/build/download_nacl_toolchains.py
@@ -13,6 +13,7 @@ def Main(args):
   # Exit early if disable_nacl=1.
   if 'disable_nacl=1' in os.environ.get('GYP_DEFINES', ''):
     return 0
+
   script_dir = os.path.dirname(os.path.abspath(__file__))
   src_dir = os.path.dirname(script_dir)
   nacl_dir = os.path.join(src_dir, 'native_client')
@@ -34,8 +35,13 @@ def Main(args):
   # gclient sync time for developers, or standard Chrome bots.
   if '--optional-pnacl' in args:
     args.remove('--optional-pnacl')
+    use_pnacl = False

[robertm, 2012/03/26 14:30:44]

I am not sure whether we should hook into the optional-pnacl
hook. I believe this was meant for the SDK bots only.

I'll add noealallan to the reviewer list.

In any case, the comment should probably be augmented to
reflect the extra magic. 

[Nikolay, 2012/03/26 14:59:56]

Well, from what I see regular gclient runhooks use 
"--optional-pnacl" switch. I just wanted minimal changes,
but can move it up, if you believe it makes sense. 
Comment added.

On 2012/03/26 14:30:44, robertm wrote:

+    if 'target_arch=arm' in os.environ.get('GYP_DEFINES', ''):
+      use_pnacl = True
     buildbot_name = os.environ.get('BUILDBOT_BUILDERNAME', '')
     if buildbot_name.find('pnacl') >= 0 and  buildbot_name.find('sdk') >= 0:
+      use_pncal = True
+    if use_pnacl:
       print '\n*** DOWNLOADING PNACL TOOLCHAIN ***\n'
     else:
       args.append('--no-pnacl')
@@ -46,4 +52,3 @@ def Main(args):
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv[1:]))
-