Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2228)

Unified Diff: build/download_nacl_toolchains.py

Issue 9838005: Support for ARM NaCl untrusted runtime build. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Back to Chrome Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/native_client/native_client.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/download_nacl_toolchains.py
diff --git a/build/download_nacl_toolchains.py b/build/download_nacl_toolchains.py
index 2fdfa00f37c7fa9f72db6ed79c3c88ca25ae74f2..6b00841155d724a6a9ed6f868f99a71ab75c9ef1 100755
--- a/build/download_nacl_toolchains.py
+++ b/build/download_nacl_toolchains.py
@@ -34,8 +34,18 @@ def Main(args):
# gclient sync time for developers, or standard Chrome bots.
if '--optional-pnacl' in args:
args.remove('--optional-pnacl')
+ # By default we don't use PNaCl toolchain yet, unless on ARM, where
+ # there is no other toolchain to build untrusted code at the moment.
+ # So analyze if we're building for ARM, or on SDK buildbot.
+ # TODO(olonho): we need to invent more reliable way to get build
+ # configuration info, to know if we're building for ARM.
+ use_pnacl = False
+ if 'target_arch=arm' in os.environ.get('GYP_DEFINES', ''):
+ use_pnacl = True
buildbot_name = os.environ.get('BUILDBOT_BUILDERNAME', '')
if buildbot_name.find('pnacl') >= 0 and buildbot_name.find('sdk') >= 0:
+ use_pnacl = True
+ if use_pnacl:
print '\n*** DOWNLOADING PNACL TOOLCHAIN ***\n'
else:
args.append('--no-pnacl')
@@ -46,4 +56,3 @@ def Main(args):
if __name__ == '__main__':
sys.exit(Main(sys.argv[1:]))
-
« no previous file with comments | « no previous file | ppapi/native_client/native_client.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698