Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: chrome/browser/ui/intents/web_intent_picker_controller.h

Issue 9838003: Revert 128189 - [Web Intents] Inline installation of extensions in web intents picker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/intents/web_intent_picker_controller.h
===================================================================
--- chrome/browser/ui/intents/web_intent_picker_controller.h (revision 128190)
+++ chrome/browser/ui/intents/web_intent_picker_controller.h (working copy)
@@ -9,11 +9,9 @@
#include <vector>
#include "base/compiler_specific.h"
-#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/string16.h"
-#include "chrome/browser/extensions/webstore_installer.h"
#include "chrome/browser/favicon/favicon_service.h"
#include "chrome/browser/intents/web_intents_registry.h"
#include "chrome/browser/intents/cws_intents_registry.h"
@@ -29,7 +27,6 @@
class TabContentsWrapper;
class WebIntentPicker;
class WebIntentPickerModel;
-class WebstoreInstaller;
namespace content {
class WebContents;
@@ -44,7 +41,7 @@
// intent handler choice back to the TabContents object.
class WebIntentPickerController : public content::NotificationObserver,
public WebIntentPickerDelegate,
- public WebstoreInstaller::Delegate {
+ public WebIntentsRegistry::Consumer {
public:
// Takes ownership of |factory|.
explicit WebIntentPickerController(TabContentsWrapper* wrapper);
@@ -72,15 +69,9 @@
Disposition disposition) OVERRIDE;
virtual void OnInlineDispositionWebContentsCreated(
content::WebContents* web_contents) OVERRIDE;
- virtual void OnExtensionInstallRequested(const std::string& id) OVERRIDE;
virtual void OnCancelled() OVERRIDE;
virtual void OnClosing() OVERRIDE;
- // WebstoreInstaller::Delegate implementation.
- virtual void OnExtensionInstallSuccess(const std::string& id) OVERRIDE;
- virtual void OnExtensionInstallFailure(const std::string& id,
- const std::string& error) OVERRIDE;
-
private:
friend class WebIntentPickerControllerTest;
friend class WebIntentPickerControllerBrowserTest;
@@ -100,9 +91,15 @@
}
// Called when WebIntentServiceData is returned from the WebIntentsRegistry.
- void OnWebIntentServicesAvailable(
- const std::vector<webkit_glue::WebIntentServiceData>& services);
+ virtual void OnIntentsQueryDone(
+ WebIntentsRegistry::QueryID,
+ const std::vector<webkit_glue::WebIntentServiceData>& services) OVERRIDE;
+ // Called when the WebIntentsRegistry returns responses to a defaults request.
+ virtual void OnIntentsDefaultsQueryDone(
+ WebIntentsRegistry::QueryID,
+ const DefaultWebIntentService& default_service) OVERRIDE;
+
// Called when FaviconData is returned from the FaviconService.
void OnFaviconDataAvailable(FaviconService::Handle handle,
history::FaviconData favicon_data);
@@ -130,12 +127,6 @@
// Called when an extension's icon failed to be decoded or resized.
void OnExtensionIconUnavailable(const string16& extension_id);
- // When an extension is installed, all that is known is the extension id.
- // This callback receives the intent service data for that extension.
- // |services| must be a non-empty list.
- void OnExtensionInstallServiceAvailable(
- const std::vector<webkit_glue::WebIntentServiceData>& services);
-
// Decrements the |pending_async_count_| and notifies the picker if it
// reaches zero.
void AsyncOperationFinished();
@@ -177,9 +168,6 @@
// Request consumer used when asynchronously loading favicons.
CancelableRequestConsumerTSimple<size_t> favicon_consumer_;
- // Used to install extensions from the Chrome Web Store.
- scoped_refptr<WebstoreInstaller> webstore_installer_;
-
base::WeakPtrFactory<WebIntentPickerController> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(WebIntentPickerController);
« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker.h ('k') | chrome/browser/ui/intents/web_intent_picker_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698