Issue 9838003: Revert 128189 - [Web Intents] Inline installation of extensions in web intents picker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9838003: Revert 128189 - [Web Intents] Inline installation of extensions in web intents picker. (Closed)

Created:
8 years, 9 months ago by Hironori Bono

Modified:
8 years, 9 months ago

Reviewers:
binji

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 128189 - [Web Intents] Inline installation of extensions in web intents picker. Initial CL: http://codereview.chromium.org/9595031/ Second try: http://codereview.chromium.org/9763001/ BUG=113476 TEST=WebIntentsRegistryTest.GetIntentServicesForExtensionFilter, WebIntentPickerControllerBrowserTest.ExtensionInstallSuccess TBR=rsesek@chromium.org Review URL: http://codereview.chromium.org/9799001 TBR=binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128191

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+94 lines, -400 lines)			Patch
M	chrome/browser/intents/web_intents_registry.h	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	chrome/browser/intents/web_intents_registry.cc	View	4 chunks	+13 lines, -74 lines	0 comments	Download
M	chrome/browser/intents/web_intents_registry_unittest.cc	View	4 chunks	+0 lines, -35 lines	0 comments	Download
M	chrome/browser/ui/cocoa/web_intent_sheet_controller_unittest.mm	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller.h	View	7 chunks	+9 lines, -21 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller.cc	View	11 chunks	+20 lines, -121 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc	View	15 chunks	+52 lines, -109 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_delegate.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_model.h	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_model.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

8 years, 9 months ago (2012-03-22 10:29:24 UTC) #2

Greetings,

Apologies for reverting your change. Unfortunately, I have reverted your r128189
due to build breaks as listed below.
* Linux x64

http://chromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/25434/...
* Mac Builder

http://chromegw.corp.google.com/i/chromium/builders/Mac%20Builder/builds/3354...
* Win Builder

http://chromegw.corp.google.com/i/chromium/builders/Win%20Builder/builds/2628...

Even though it is just a typo (kType -> kType1) at Line 413 in
'chrome/browser/ui/intents/web_intent_picker_browsertest.cc' and pretty easy to
fix these breaks, I reverted your change because I could not find owners of
'chrome/browser/ui/intents'. Is it possible to update your change and re-land
the updated one?

Regards,

Hironori Bono

Expand Messages | Collapse Messages