Source/WebCore/bindings/dart/DartController.cpp - Issue 9837116: DOM wrappers that are not retained from Dart should be collected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/bindings/dart/DartController.cpp

Issue 9837116: DOM wrappers that are not retained from Dart should be collected. (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit

Patch Set: Address comments. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/WebCore/bindings/dart/DartController.cpp

diff --git a/Source/WebCore/bindings/dart/DartController.cpp b/Source/WebCore/bindings/dart/DartController.cpp

index ec81237b7758786271ba771f24f7deeb885f7415..ceee333c51eec62f13de33288b3b617b2edc1aa6 100644

--- a/Source/WebCore/bindings/dart/DartController.cpp

+++ b/Source/WebCore/bindings/dart/DartController.cpp

@@ -135,9 +135,7 @@ void DartController::clearWindowShell()

for (size_t i = 0; i < m_isolates.size(); ++i) {

DartIsolate::Scope scope(m_isolates[i]);

- DartDOMMap* domMap = DartUtilities::domMapForCurrentIsolate();

- for (DartDOMMap::iterator it = domMap->begin(); it != domMap->end(); ++it)

- DartDOMWrapper::derefDOMObject(it->second, it->first);

+ DartUtilities::disposeWeakPersistentHandles();

}

for (size_t i = 0; i < m_isolates.size(); ++i) {