Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: Source/WebCore/bindings/dart/DartController.cpp

Issue 9837116: DOM wrappers that are not retained from Dart should be collected. (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/bindings/dart/DartController.cpp
diff --git a/Source/WebCore/bindings/dart/DartController.cpp b/Source/WebCore/bindings/dart/DartController.cpp
index 37a485f62a6a91d15e17665d4ffe616f01fa958e..d870e9b2308417c71d971645db2a95dc4fc92fc0 100644
--- a/Source/WebCore/bindings/dart/DartController.cpp
+++ b/Source/WebCore/bindings/dart/DartController.cpp
@@ -97,21 +97,6 @@ PassRefPtr<DartIsolate> DartController::createIsolate(Document* document, PassRe
return dartIsolate.release();
}
-void DartController::shutdownIsolate(DartIsolate* isolate)
-{
- Dart_Isolate currentIsolate = Dart_CurrentIsolate();
- if (currentIsolate)
- Dart_ExitIsolate();
- Dart_EnterIsolate(isolate->isolate());
- Dart_ShutdownIsolate();
- if (currentIsolate)
- Dart_EnterIsolate(currentIsolate);
-
- *DartUtilities::recursionForIsolate(isolate->isolate()) = 0;
- DartUtilities::unregisterIsolate(isolate->isolate());
- DartDebugServer::shared().unregisterIsolate(isolate);
-}
-
DartController::DartController(Frame* frame)
: m_frame(frame)
, m_scriptsLoaded(false)
@@ -131,16 +116,6 @@ DartController::DartController(Frame* frame)
void DartController::clearWindowShell()
{
m_scriptsLoaded = false;
-
- for (size_t i = 0; i < m_isolates.size(); ++i) {
- DartIsolate::Scope scope(m_isolates[i]);
- // FIXME: clear event listeners.
- // FIXME: clear console messages.
- DartDOMMap* domMap = DartUtilities::domMapForCurrentIsolate();
- for (DartDOMMap::iterator it = domMap->begin(); it != domMap->end(); ++it)
- DartDOMWrapper::derefDOMObject(it->second, it->first);
- }
-
m_isolates.clear();
}

Powered by Google App Engine
This is Rietveld 408576698